Fixes T9131. As of D13579, unit tests results were no longer rendered progressively. The issue here is that the rendering is being done in ArcanistConfigurationDrivenUnitTestEngine rather than in the child test engines, and only after $engine->run() had returned (i.e. after all tests within a test engine had completed).
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T9131: `arc unit` doesn't output progressive results
Ran arc unit, saw progressive results.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8853 Build 10346: Run Core Tests Build 10345: arc lint + arc unit
Event Timeline
Comment Actions
@epriestley, it looks like this was landed (and squashed) when I used "land revision" for D14487. Is that expected? Locally, I had submitted D14487 on top of D14037, although there's no logical relatiionship between the two diffs.
Comment Actions
As mentioned, this was inadvertently landed in rARC66ab1c955d27ff7875f62eb51a0bd6c4770a7ae3. @epriestley, we can revert this commit of you want and I will resubmit the diffs.
Comment Actions
Yes, that's the expected behavior (just like arc land would try to do if you had the two changes on top of one another).
We can just leave this in, I guess.
Comment Actions
I think that this is not desirable behavior. In this particular case, I completely forgot that I had submitted the three diffs on top of each other, and so clicking "Land Revision" and seeing all three squashed into one was surprising. If I had used arc land locally then I could have verified the state before pushing.
Comment Actions
The button will cease to work in this case in the future, rejecting the land because it would land unlanded, unreviewed commits. But will always mean "land this state", just like arc land does.