HomePhabricator

Prevent double rendering of unit test results

Description

Prevent double rendering of unit test results

Summary: D14037 had the logic slightly wrong and unit test results are now being double rendered.

Test Plan: Ran a unit test with arc unit -- path/to/test and saw the results rendered only once.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14495

Details

Event Timeline

That test may actually have been broken by D14498.

Yes, I should have landed D14499 before this one.

I don't seem to get an email when Harbormaster builds fail from this install, but I do on our private install... Presumably I have somehow silenced these.

You can theoretically fish around in /mail/ to figure out what happened to messages. I think some of the Harbormaster integration is still rough around the edges so it might not be your fault.

Yeah the mail tag is audit-other, which I have set to notify only.