Page MenuHomePhabricator

Prevent double rendering of unit test results
ClosedPublic

Authored by joshuaspence on Nov 16 2015, 7:48 PM.

Details

Summary

D14037 had the logic slightly wrong and unit test results are now being double rendered.

Test Plan

Ran a unit test with arc unit -- path/to/test and saw the results rendered only once.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joshuaspence retitled this revision from to Prevent double rendering of unit test results.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley accepted this revision.Nov 16 2015, 8:52 PM
epriestley edited edge metadata.

Maybe add a comment explaining why !$thing causes $thing to occur.

This revision is now accepted and ready to land.Nov 16 2015, 8:52 PM
This revision was automatically updated to reflect the committed changes.

@epriestley's comment shows why shouldEchoTestResults is a bad name for this method. A name like testEngineWillEchoTestResults is also awful, but it better communicates the purpose. The problem is that there is no subject in the name. It would be clearer if the method were rendererShouldEchoTestResults and the logic were inverted.