Memoize paths
Audit Required46ce8a5a35f9
Actions

Description

Memoize paths

Summary: Ref T7892. Memoize paths returned from ARcanistLinter::getPaths() to improve runtime performance.

Test Plan: Wiped ~0.5 seconds off the total time to lint rARC.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T7892

Differential Revision: https://secure.phabricator.com/D12520

Details

Group Auditors

Unknown Object (Owners Package)

Provenance

joshuaspence	Authored on
joshuaspence	Pushed on Apr 27 2015, 1:21 PM

Reviewer

Blessed Reviewers

Differential Revision

D12520: Memoize paths

Parents

rARC805ae12408e8: Remove vqueryfx from linters

Branches

Unknown

Tags

Unknown

Tasks

T7892: Investigate lint performance issues

Event Timeline

joshuaspence committed rARC46ce8a5a35f9: Memoize paths (authored by joshuaspence).Apr 27 2015, 1:20 PM

joshuaspence added a task: T7892: Investigate lint performance issues.

matthewrbowker mentioned this in T4445: Diffusion tag cache not updating correctly when tags move?.Jul 24 2015, 5:50 PM

yingjun added a subscriber: yingjun.Aug 13 2015, 7:59 PM

yingjun added inline comments.

/src/lint/linter/ArcanistLinter.php
323	is_null?

Changes (1)

Path

Size

src/

lint/

linter/

ArcanistLinter.php

rARC46ce8a5a35f9

View Options

src/lint/linter/ArcanistLinter.php