Page MenuHomePhabricator
Differential D11642

Fix text lint issues
ClosedPublic
Actions

Authored by joshuaspence on Feb 3 2015, 10:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 25, 12:14 AM
Unknown Object (File)
Mon, Jul 22, 1:49 PM
Unknown Object (File)
Mon, Jul 22, 1:28 PM
Unknown Object (File)
Thu, Jul 18, 7:54 AM
Unknown Object (File)
Sat, Jul 13, 4:00 PM
Unknown Object (File)
Wed, Jul 10, 4:26 PM
Unknown Object (File)
Tue, Jul 9, 11:09 PM
Unknown Object (File)
Sat, Jul 6, 10:41 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings
Commits
Restricted Diffusion Commit
rP2a2b47326c81: Fix text lint issues
Summary

Ref T5105. This is a proof-of-concept for D11458.

Test Plan

arc lint --everything

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4429
Build 4443: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 28020.Feb 3 2015, 10:42 AM
joshuaspence retitled this revision from to Fix text lint issues.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D11458: Modify `ArcanistTextLinter` to respect `.editorconfig`.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 3 2015, 10:42 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley added inline comments.Feb 3 2015, 7:47 PM
.arclint
17–40

These don't seem related to text lint?

joshuaspence added inline comments.Feb 3 2015, 7:55 PM
.arclint
17–40

Oh whoops... I disabled these to make the output of arc lint less noisy.

joshuaspence updated this revision to Diff 28051.Feb 3 2015, 7:56 PM
joshuaspence edited edge metadata.

derp

epriestley accepted this revision.Feb 3 2015, 7:57 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 7:57 PM
joshuaspence updated this object.Feb 10 2015, 8:47 AM
joshuaspence edited edge metadata.
joshuaspence added a task: T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings.
joshuaspence updated this revision to Diff 28258.Feb 10 2015, 10:00 AM

Minor changes

joshuaspence updated this revision to Diff 28259.Feb 10 2015, 10:09 AM

Minor changes

Closed by commit rP2a2b47326c81: Fix text lint issues (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 11 2015, 8:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
89 lines
18 lines
1 line
src/
applications/
diffusion/
data/
__tests__/
22 lines
docs/
book/
34 lines
44 lines
394 lines
56 lines
webroot/
rsrc/
externals/
javelin/
10 lines

Diff 28258

View Options

.arclint

Loading...
View Options

.editorconfig

Loading...
View Options

LICENSE

Loading...
View Options

src/applications/diffusion/data/__tests__/DiffusionGitBranchTestCase.php

Loading...
View Options

src/docs/book/contributor.book

Loading...
View Options

src/docs/book/flavor.book

Loading...
View Options

src/docs/book/phabricator.book

Loading...
View Options

src/docs/book/user.book

Loading...
View Options

webroot/rsrc/externals/javelin/LICENSE

Loading...
Phabricator · Built by Phacility