Page MenuHomePhabricator

Migrate Maniphest task blockers to modern EdgeType classes
ClosedPublic

Authored by Krenair on Dec 28 2014, 3:50 AM.
Tags
None
Referenced Files
F14170017: D11045.id26525.diff
Sat, Dec 7, 6:15 PM
Unknown Object (File)
Fri, Nov 22, 8:29 PM
Unknown Object (File)
Mon, Nov 11, 7:30 AM
Unknown Object (File)
Nov 4 2024, 7:54 AM
Unknown Object (File)
Oct 28 2024, 6:50 PM
Unknown Object (File)
Oct 21 2024, 1:28 AM
Unknown Object (File)
Oct 17 2024, 3:40 AM
Unknown Object (File)
Oct 16 2024, 7:32 AM
Tokens
"Doubloon" token, awarded by epriestley.

Details

Summary

Prevents "edited tasks, added: 1; removed: 1"

Fixes T6757, using D9839 as an example

Test Plan

Added and removed blockers to/from tasks, saw the expected history entries.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Krenair retitled this revision from to Migrate Maniphest task blockers to modern EdgeType classes.
Krenair updated this object.
Krenair edited the test plan for this revision. (Show Details)
Krenair added a reviewer: epriestley.
epriestley edited edge metadata.

Looks great, thanks!

This revision is now accepted and ready to land.Dec 28 2014, 2:10 PM
src/infrastructure/edges/constants/PhabricatorEdgeConfig.php
199–200

Oh, one other minor thing -- this should be a shouldPreventCycles() implementation in the new EdgeType class. Otherwise, users can create T1 -> T2 -> T1, etc., which messes a few things up a bit. I'll just fix that in the pull.

src/applications/maniphest/edge/ManiphestTaskDependsOnTaskEdgeType.php
84

Oh, and in doing "edited blocking task(s)", these feed strings are slightly off.

The reason there are different "transaction" and "feed" strings is that the "transaction" strings are shown on the object, so the edited object is implicit (e.g., alincoln edited this object.). The "feed" strings are shown elsewhere (normally, in feed) so the edited object is not implicit and must be explicit (alincoln edited T123: foobar). If the object is excluded, the affected object isn't clear in the feed story:

Screen_Shot_2014-12-28_at_6.32.42_AM.png (189×623 px, 21 KB)

Specifically, the viewer can't tell which task relationships were edited for unless the object is included in the string.

This revision was automatically updated to reflect the committed changes.