Page MenuHomePhabricator
Create Task
Maniphest T6757

Removing a blocker while adding a blocker results in "edited tasks, added: 1; removed: 1"
Closed, ResolvedPublic
Actions

Description

... which isn't very useful. Downstream report of the same bug: https://phabricator.wikimedia.org/T78250
Example: https://phabricator.wikimedia.org/T911#836398

Revisions and Commits

rP Phabricator
D11045rP102e431feb01 Migrate Maniphest task blockers to modern EdgeType classes

Related Objects

Event Timeline

Krenair created this task.Dec 15 2014, 10:31 PM
Krenair raised the priority of this task from to Needs Triage.
Krenair updated the task description. (Show Details)
Krenair added a project: Maniphest.
Krenair added a subscriber: Krenair.
Herald added a subscriber: qgil. · View Herald TranscriptDec 15 2014, 10:31 PM
epriestley triaged this task as Low priority.Dec 15 2014, 10:52 PM
epriestley added a subscriber: epriestley.

To resolve this:

  • Convert TYPE_TASK_DEPENDS_ON_TASK and TYPE_TASK_DEPENDED_ON_BY_TASK to modern EdgeType classes (see D9839 for an example).
  • Provide appropriate get...String() implementations.
  • Implement English translations in PhabricatorBaseEnglishTranslation.
aklapper added a subscriber: aklapper.Dec 15 2014, 11:08 PM
chad added a project: Transactions.Dec 20 2014, 4:27 AM
joshuaspence added a subscriber: joshuaspence.Dec 24 2014, 7:10 AM
Krenair claimed this task.Dec 28 2014, 3:36 AM

Not quite sure about my PhabricatorBaseEnglishTranslation changes, but uploading.

Krenair added a revision: D11045: Migrate Maniphest task blockers to modern EdgeType classes.Dec 28 2014, 3:50 AM
epriestley added a comment.EditedDec 28 2014, 2:15 PM

I think the changes are correct. A very slightly cleaner way to do it without the ambiguities might be to make the string "...edited blocking task(s)...", maybe I'll tweak that in the pull.

The "%d" -> "%s" change is because we're using PhutilNumber in EdgeType, which gives us locale-aware rendering (e.g., 1,234.56 vs 1.234,56).

epriestley closed this task as Resolved.Dec 28 2014, 2:41 PM
epriestley added a commit: rP102e431feb01: Migrate Maniphest task blockers to modern EdgeType classes.

Closed by commit rP102e431feb01.

epriestley added a comment.Dec 28 2014, 2:42 PM

I think the slightly adjusted version I landed fixes this, but yell if I missed anything. If there is anything off it should be an easy fix (tweak a string table) now that @Krenair did all the legwork.

Screen_Shot_2014-12-28_at_6.40.04_AM.png (178×552 px, 31 KB)

Screen_Shot_2014-12-28_at_6.40.17_AM.png (583×621 px, 67 KB)

epriestley mentioned this in T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog.Dec 28 2014, 2:53 PM
Phabricator · Built by Phacility