Page MenuHomePhabricator

Modernize Legalpad edge types
ClosedPublic

Authored by joshuaspence on Dec 30 2014, 12:28 PM.
Tags
None
Referenced Files
F18836407: D11082.id26657.diff
Mon, Oct 27, 12:49 AM
F18813960: D11082.diff
Mon, Oct 20, 8:20 PM
F18712301: D11082.id.diff
Sep 29 2025, 5:21 AM
F18618807: D11082.diff
Sep 15 2025, 12:57 AM
F18616096: D11082.id.diff
Sep 14 2025, 4:14 PM
F18601248: D11082.diff
Sep 13 2025, 11:55 AM
F18504560: D11082.id.diff
Sep 4 2025, 11:53 PM
F18495854: D11082.diff
Sep 4 2025, 4:58 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP83d1e3edb59b: Modernize Legalpad edge types
Summary

Modernize Legalpad edges to subclass PhabricatorEdgeType. Largely based on D11045.

Test Plan
  1. Created a Herald rule to require legal signatures on all diffs.
  2. Created a new diff.
  3. Saw the transaction string appear correctly.

I wasn't able to check the inverse transaction because there is none. Also, I couldn't see any text on the feed (presumably, transactions authored by Herald do not generate feed items)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Modernize Legalpad edge types.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.

Don't write inverse transactions

joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 31 2014, 4:03 PM
This revision was automatically updated to reflect the committed changes.