Paths

Table of Contentst

Differential D10535

Add a linter rule for array separators
ClosedPublic
Actions

Authored by joshuaspence on Sep 22 2014, 8:41 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCbe428e320700: Add a linter rule for array separators

Summary

Adds a rule to ArcanistXHPASTLinter which ensures that:

Single-lined arrays do not contain an unnecessary trailing comma separator after the final array value.
Multi-lined arrays do contain a trailing comma seperator after the final value value.

Depends on D10534.

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository

rARC Arcanist

Branch

arraycomma

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2602
Build 2606: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25311.Sep 22 2014, 8:41 AM

joshuaspence retitled this revision from to Add a linter rule for array separators.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D10534: Add a `getEndLineNumber` method to the `AASTNode` class.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 22 2014, 8:41 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2602: Diff 25311.Sep 22 2014, 8:41 AM

joshuaspence mentioned this in D10534: Add a `getEndLineNumber` method to the `AASTNode` class.Sep 22 2014, 8:45 AM

Also, I'm not sure whether "separator" is the correct terminology here...

I think this is reasonable. I can't immediately come up with a more useful term to describe the comma than "array separator".

src/lint/linter/ArcanistXHPASTLinter.php
199	(Minor, but same version bump as D10538.)

This revision is now accepted and ready to land.Sep 24 2014, 9:05 PM

Closed by commit rARCbe428e320700: Add a linter rule for array separators (authored by joshuaspence, committed by joshuaspence).Sep 24 2014, 9:41 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D10558: Fix `LINT_ARRAY_SEPARATOR` for nested arrays.Sep 25 2014, 2:53 AM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

48 lines

__tests__/

xhpast/

array-comma.lint-test

30 lines

Diff 25311

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/array-comma.lint-test

Add a linter rule for array separatorsClosedPublicActions