Page MenuHomePhabricator
Differential D10538

Raise a linter error when removed symbols are used
ClosedPublic
Actions

Authored by joshuaspence on Sep 22 2014, 2:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 7, 11:24 PM
Unknown Object (File)
Fri, Feb 7, 11:24 PM
Unknown Object (File)
Fri, Feb 7, 11:24 PM
Unknown Object (File)
Fri, Feb 7, 11:24 PM
Unknown Object (File)
Thu, Jan 30, 7:08 AM
Unknown Object (File)
Wed, Jan 29, 4:19 AM
Unknown Object (File)
Mon, Jan 27, 1:46 PM
Unknown Object (File)
Thu, Jan 23, 4:51 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5141: `ArcanistXHPASTLinter` should raise warnings when deprecated functions are used
Commits
rARCa10002adec13: Raise a linter error when removed symbols are used
Summary

Ref T5141. Utilize the 'max' key from the php_compat_info.json compatibility map to lint for the use of classes/functions/symbols which have been removed from the target PHP version.

Test Plan

Added a test case for arc unit.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 25318.Sep 22 2014, 2:23 PM
joshuaspence retitled this revision from to Raise a linter error when removed symbols are used.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 22 2014, 2:23 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2607: Diff 25318.Sep 22 2014, 2:24 PM
joshuaspence added a comment.Sep 22 2014, 9:48 PM

FWIW, "removed symbols" is possibly not quite correct, but I couldn't think of a better wording

epriestley accepted this revision.Sep 24 2014, 9:02 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 24 2014, 9:02 PM
epriestley mentioned this in D10535: Add a linter rule for array separators.Sep 24 2014, 9:05 PM
joshuaspence updated this object.Jan 4 2015, 7:37 AM
joshuaspence edited edge metadata.
joshuaspence added a task: T5141: `ArcanistXHPASTLinter` should raise warnings when deprecated functions are used.
Closed by commit rARCa10002adec13: Raise a linter error when removed symbols are used (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 4 2015, 7:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
122 lines
__tests__/
xhpast/
10 lines

Diff 26864

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/php-compatibility.lint-test

Loading...
Phabricator · Built by Phacility