Page MenuHomePhabricator

Fix `LINT_ARRAY_SEPARATOR` for nested arrays
ClosedPublic

Authored by joshuaspence on Sep 25 2014, 2:53 AM.
Tags
None
Referenced Files
F15507703: D10558.diff
Tue, Apr 15, 10:05 PM
F15488796: D10558.id25383.diff
Fri, Apr 11, 2:57 AM
F15488105: D10558.id25381.diff
Thu, Apr 10, 7:33 PM
F15488078: D10558.id25364.diff
Thu, Apr 10, 7:09 PM
F15487823: D10558.id.diff
Thu, Apr 10, 5:07 PM
F15487446: D10558.diff
Thu, Apr 10, 2:08 PM
F15483315: D10558.diff
Wed, Apr 9, 11:46 AM
F15469977: D10558.id25364.diff
Fri, Apr 4, 6:45 PM
Subscribers

Details

Summary

The LINT_ARRAY_SEPARATOR rule was added to ArcanistXHPASTLinter in D10535. Unfortunately, it does not correctly handle nested arrays correctly. This patch fixes this. Depends on D10554.

Test Plan

Added a test case.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Fix `LINT_ARRAY_SEPARATOR` for nested arrays.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

Another possible issue:

     $keys = array(
       'key1' => mt_rand(),
       'key2' => '',
-      'key3' => 'Phabricator');
+      'key3' => 'Phabricator',);
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 25 2014, 1:26 PM
This revision was automatically updated to reflect the committed changes.