HomePhabricator

Fix a fatal error in `ArcanistXHPASTLinter`

Description

Fix a fatal error in ArcanistXHPASTLinter

Summary: I had assumed that we would always be interested in n_STATEMENT_LIST, which is fine for if (...) { some_statements(); } but not for if (...) one_statement();.

Test Plan: Added a test case.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10551

Details

Provenance
joshuaspenceAuthored on
joshuaspencePushed on Sep 24 2014, 9:33 PM
Reviewer
Blessed Reviewers
Differential Revision
D10551: Fix a fatal error in `ArcanistXHPASTLinter`
Parents
rARC888ada2f380c: Improve `LINT_DOS_NEWLINE` behavior
Branches
Unknown
Tags
Unknown

Event Timeline