(stable) Don't apply patches or mark patches applied with `bin/storage upgrade…
b0df33e6ecd7
Actions

Description

(stable) Don't apply patches or mark patches applied with bin/storage upgrade --dryrun

Summary: Fixes T12682.

Test Plan: Ran bin/storage upgrade --dryrun repeatedly with un-applied patches, saw it not apply them and not mark them applied.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12682

Differential Revision: https://secure.phabricator.com/D17837

Details

Provenance

epriestley	Authored on May 6 2017, 2:55 AM
epriestley	Pushed on May 6 2017, 2:57 AM

Reviewer

chad

Differential Revision

D17837: Don't apply patches or mark patches applied with `bin/storage upgrade --dryrun`

Parents

rP22c3e49b5176: (stable) Fix file attach bug in Macro

Branches

Unknown

Tags

Unknown

Tasks

T12682: `storage --dry-run` actually looks rather wet when applying patches

Build Status

Buildable 16839
Build 22474: Run Core Tests

Event Timeline

epriestley committed rPb0df33e6ecd7: (stable) Don't apply patches or mark patches applied with `bin/storage upgrade… (authored by epriestley).May 6 2017, 2:57 AM

epriestley added a task: T12682: `storage --dry-run` actually looks rather wet when applying patches.

Harbormaster completed building B16839: rPb0df33e6ecd7: (stable) Don't apply patches or mark patches applied with `bin/storage upgrade….May 6 2017, 2:59 AM

cxzzero mentioned this in T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows.May 8 2017, 2:26 PM

mormegil mentioned this in T12701: Harbormaster does not ignore additional whitespace in HTTP URLs, making invalid HTTP requests.May 10 2017, 10:17 AM

Changes (1)

Path

Size

src/

infrastructure/

storage/

management/

workflow/

PhabricatorStorageManagementWorkflow.php

rPb0df33e6ecd7

View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php