Paths

Table of Contentst

Differential D17837

Don't apply patches or mark patches applied with `bin/storage upgrade --dryrun`
ClosedPublic
Actions

Authored by epriestley on May 6 2017, 2:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Feb 26, 2:04 AM

	Unknown Object (File)
	Wed, Feb 19, 8:45 PM

	Unknown Object (File)
	Tue, Feb 18, 9:32 AM

	Unknown Object (File)
	Fri, Feb 14, 4:53 PM

	Unknown Object (File)
	Sun, Feb 9, 2:35 PM

	Unknown Object (File)
	Sun, Feb 9, 3:57 AM

	Unknown Object (File)
	Sun, Feb 9, 3:57 AM

	Unknown Object (File)
	Sun, Feb 9, 3:57 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12682: `storage --dry-run` actually looks rather wet when applying patches

Commits

rPb0df33e6ecd7: (stable) Don't apply patches or mark patches applied with `bin/storage upgrade…
rPbcd87e0e3f37: Don't apply patches or mark patches applied with `bin/storage upgrade --dryrun`

Summary

Fixes T12682.

Test Plan

Ran bin/storage upgrade --dryrun repeatedly with un-applied patches, saw it not apply them and not mark them applied.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 6 2017, 2:56 AM

chad accepted this revision.May 6 2017, 2:56 AM

This revision is now accepted and ready to land.May 6 2017, 2:56 AM

Closed by commit rPbcd87e0e3f37: Don't apply patches or mark patches applied with `bin/storage upgrade --dryrun` (authored by epriestley, committed by epriestley). · Explain WhyMay 6 2017, 2:57 AM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B16836: Diff 42910.May 6 2017, 2:58 AM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

storage/

management/

workflow/

PhabricatorStorageManagementWorkflow.php

8 lines

Diff 42911

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...