HomePhabricator

(stable) Fix file attach bug in Macro

Tags
None
Referenced Files
None
Subscribers
None
Tokens
"Burninate" token, awarded by chad.

Description

(stable) Fix file attach bug in Macro

Summary: This was mis-tested by only using one account, which could always see the image. External transaction moved file attachment to the modular transaction for file and audio instead.

Test Plan: Test adding audio and a macro on a pleb account, visit with normal account and see macro fine.

Reviewers: epriestley, amckinley

Reviewed By: amckinley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17836

Details

Provenance
Chad Little <chad@phacility.com>Authored on May 6 2017, 2:50 AM
epriestleyCommitted on May 6 2017, 2:57 AM
epriestleyPushed on May 6 2017, 2:57 AM
Reviewer
amckinley
Differential Revision
D17836: Fix file attach bug in Macro
Parents
rPebb64ca3c9d4: (stable) Promote 2017 Week 18
Branches
Unknown
Tags
Unknown
Build Status
Buildable 16838
Build 22473: Run Core Tests