Page MenuHomePhabricator

Add an explicit warning in the Differential transaction log when users skip review
ClosedPublic

Authored by epriestley on Nov 30 2017, 4:26 PM.
Tags
None
Referenced Files
F12828417: D18808.id45125.diff
Thu, Mar 28, 10:45 AM
Unknown Object (File)
Feb 26 2024, 10:12 AM
Unknown Object (File)
Nov 30 2023, 4:51 AM
Unknown Object (File)
Nov 22 2023, 5:20 PM
Unknown Object (File)
Nov 17 2023, 6:50 PM
Unknown Object (File)
Nov 8 2023, 4:57 AM
Unknown Object (File)
Oct 30 2023, 3:06 PM
Unknown Object (File)
Oct 19 2023, 2:56 PM
Subscribers
None

Details

Summary

Ref T10233. See PHI231. When users ignore the arc land prompt about bad revision states, make it explicitly clear in the transaction log that they broke the rules.

You can currently figure this out by noticing that there's no "This revision is accepted and ready to land." message, but it's unrealistic to expect non-expert users to look for the absence of a message to indicate something, and this state change is often relevant.

Test Plan

Screen Shot 2017-11-30 at 8.23.14 AM.png (129×633 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

webroot/rsrc/css/phui/phui-timeline-view.css
318–320

I also remedied this critical omission.

This revision is now accepted and ready to land.Nov 30 2017, 7:01 PM
This revision was automatically updated to reflect the committed changes.