HomePhabricator

Add more accessibility labels for screen readers

Description

Add more accessibility labels for screen readers

Summary:
Depends on D19594. See PHI823. Ref T13164.

  • Add a label for the "X" button in comment areas, like "Remove Action: Change Subscribers".
  • Add a label for the floating header display options menu in Differential.
  • Add role="button" to PHUIButtonView objects that we render with an <a ...> tag.

Test Plan:
Viewed a revision with ?__aural__=true:

  • Saw "Remove Action: ..." label.
  • Saw "Display Options" label.
  • Used inspector to verify that some <a class="button" ...> now have <a class="button" role="button" ...>. This isn't exhaustive, but at least improves things. A specific example is the "edit", "reply", etc., actions on inline comments.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13164

Differential Revision: https://secure.phabricator.com/D19595

Details

Provenance
epriestleyAuthored on Aug 17 2018, 5:53 PM
epriestleyPushed on Aug 17 2018, 8:31 PM
Reviewer
amckinley
Differential Revision
D19595: Add more accessibility labels for screen readers
Parents
rP5c4c593af325: Update DiffusionLastModifiedController to use identities
Branches
Unknown
Tags
Unknown
Tasks
T13164: Plans: 2018 Week 31 - 33 Bonus Content
Build Status
Buildable 20649
Build 28062: Run Core Tests