Page MenuHomePhabricator

Add more accessibility labels for screen readers
ClosedPublic

Authored by epriestley on Aug 17 2018, 5:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 3:10 AM
Unknown Object (File)
Mon, Nov 11, 5:41 AM
Unknown Object (File)
Tue, Nov 5, 5:43 AM
Unknown Object (File)
Thu, Oct 31, 6:41 AM
Unknown Object (File)
Oct 22 2024, 1:23 PM
Unknown Object (File)
Oct 9 2024, 9:56 AM
Unknown Object (File)
Sep 24 2024, 11:14 PM
Unknown Object (File)
Sep 13 2024, 2:40 AM
Subscribers
None

Details

Summary

Depends on D19594. See PHI823. Ref T13164.

  • Add a label for the "X" button in comment areas, like "Remove Action: Change Subscribers".
  • Add a label for the floating header display options menu in Differential.
  • Add role="button" to PHUIButtonView objects that we render with an <a ...> tag.
Test Plan

Viewed a revision with ?__aural__=true:

  • Saw "Remove Action: ..." label.
  • Saw "Display Options" label.
  • Used inspector to verify that some <a class="button" ...> now have <a class="button" role="button" ...>. This isn't exhaustive, but at least improves things. A specific example is the "edit", "reply", etc., actions on inline comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable