Page MenuHomePhabricator

Add more accessibility labels for screen readers
ClosedPublic

Authored by epriestley on Aug 17 2018, 5:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 19, 8:23 PM
Unknown Object (File)
May 26 2025, 3:24 PM
Unknown Object (File)
Apr 28 2025, 6:23 PM
Unknown Object (File)
Apr 27 2025, 9:13 PM
Unknown Object (File)
Apr 26 2025, 2:00 PM
Unknown Object (File)
Apr 23 2025, 10:18 AM
Unknown Object (File)
Apr 11 2025, 7:41 PM
Unknown Object (File)
Apr 9 2025, 7:24 PM
Subscribers
None

Details

Summary

Depends on D19594. See PHI823. Ref T13164.

  • Add a label for the "X" button in comment areas, like "Remove Action: Change Subscribers".
  • Add a label for the floating header display options menu in Differential.
  • Add role="button" to PHUIButtonView objects that we render with an <a ...> tag.
Test Plan

Viewed a revision with ?__aural__=true:

  • Saw "Remove Action: ..." label.
  • Saw "Display Options" label.
  • Used inspector to verify that some <a class="button" ...> now have <a class="button" role="button" ...>. This isn't exhaustive, but at least improves things. A specific example is the "edit", "reply", etc., actions on inline comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable