Page MenuHomePhabricator

Add more accessibility labels for screen readers
ClosedPublic

Authored by epriestley on Aug 17 2018, 5:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:14 AM
Unknown Object (File)
Fri, Apr 19, 7:52 PM
Unknown Object (File)
Thu, Apr 11, 9:40 AM
Unknown Object (File)
Mon, Apr 1, 10:12 AM
Unknown Object (File)
Mar 5 2024, 3:56 AM
Unknown Object (File)
Feb 12 2024, 12:50 AM
Unknown Object (File)
Jan 3 2024, 12:52 AM
Unknown Object (File)
Dec 25 2023, 7:08 PM
Subscribers
None

Details

Summary

Depends on D19594. See PHI823. Ref T13164.

  • Add a label for the "X" button in comment areas, like "Remove Action: Change Subscribers".
  • Add a label for the floating header display options menu in Differential.
  • Add role="button" to PHUIButtonView objects that we render with an <a ...> tag.
Test Plan

Viewed a revision with ?__aural__=true:

  • Saw "Remove Action: ..." label.
  • Saw "Display Options" label.
  • Used inspector to verify that some <a class="button" ...> now have <a class="button" role="button" ...>. This isn't exhaustive, but at least improves things. A specific example is the "edit", "reply", etc., actions on inline comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable