Page MenuHomePhabricator

Add more accessibility labels for screen readers
ClosedPublic

Authored by epriestley on Aug 17 2018, 5:56 PM.
Tags
None
Referenced Files
F15279193: D19595.diff
Mon, Mar 3, 2:16 AM
Unknown Object (File)
Wed, Feb 26, 12:41 AM
Unknown Object (File)
Mon, Feb 17, 2:21 AM
Unknown Object (File)
Sun, Feb 9, 6:20 AM
Unknown Object (File)
Sun, Feb 9, 6:20 AM
Unknown Object (File)
Sun, Feb 9, 6:20 AM
Unknown Object (File)
Jan 28 2025, 4:03 AM
Unknown Object (File)
Jan 25 2025, 1:59 AM
Subscribers
None

Details

Summary

Depends on D19594. See PHI823. Ref T13164.

  • Add a label for the "X" button in comment areas, like "Remove Action: Change Subscribers".
  • Add a label for the floating header display options menu in Differential.
  • Add role="button" to PHUIButtonView objects that we render with an <a ...> tag.
Test Plan

Viewed a revision with ?__aural__=true:

  • Saw "Remove Action: ..." label.
  • Saw "Display Options" label.
  • Used inspector to verify that some <a class="button" ...> now have <a class="button" role="button" ...>. This isn't exhaustive, but at least improves things. A specific example is the "edit", "reply", etc., actions on inline comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable