HomePhabricator

Minor improvements to the `ArcanistLintCheckstyleXMLRenderer` class.

Description

Minor improvements to the ArcanistLintCheckstyleXMLRenderer class.

Summary: Ref T4948. Move the startDocument code to a renderPreamble function so that, at least theoretically, the renderer can be reused. Otherwise, the only way to reuse the renderer would be to construct a new instance.

Test Plan: Ran arc lint --output xml and verified that the output looked reasonable.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T4948

Differential Revision: https://secure.phabricator.com/D9108

Details

Provenance
joshuaspenceAuthored on
epriestleyCommitted on May 14 2014, 12:32 AM
epriestleyPushed on May 14 2014, 12:32 AM
Reviewer
Blessed Reviewers
Differential Revision
D9108: Minor improvements to the `ArcanistLintCheckstyleXMLRenderer` class.
Parents
rARCb744ed9a19ce: Be more strict with the type of `.arclint` properties.
Branches
Unknown
Tags
Unknown
Tasks
T4948: Support checkstyle as an output format

Event Timeline