Page MenuHomePhabricator
Differential D9108

Minor improvements to the `ArcanistLintCheckstyleXMLRenderer` class.
ClosedPublic
Actions

Authored by joshuaspence on May 13 2014, 9:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 2:47 AM
Unknown Object (File)
Mon, Apr 29, 2:15 PM
Unknown Object (File)
Wed, Apr 24, 10:03 PM
Unknown Object (File)
Mar 27 2024, 9:39 PM
Unknown Object (File)
Mar 23 2024, 2:41 AM
Unknown Object (File)
Feb 16 2024, 4:42 AM
Unknown Object (File)
Feb 16 2024, 4:42 AM
Unknown Object (File)
Feb 14 2024, 8:51 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4948: Support checkstyle as an output format
Commits
rARCd484b6029505: Minor improvements to the `ArcanistLintCheckstyleXMLRenderer` class.
Summary

Ref T4948. Move the startDocument code to a renderPreamble function so that, at least theoretically, the renderer can be reused. Otherwise, the only way to reuse the renderer would be to construct a new instance.

Test Plan

Ran arc lint --output xml and verified that the output looked reasonable.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21640.May 13 2014, 9:45 PM
joshuaspence retitled this revision from to Minor improvements to the `ArcanistLintCheckstyleXMLRenderer` class..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 13 2014, 9:45 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B442: Diff 21640.May 13 2014, 9:46 PM
joshuaspence updated this object.May 13 2014, 9:46 PM
joshuaspence edited edge metadata.
joshuaspence added a task: T4948: Support checkstyle as an output format.
epriestley accepted this revision.May 14 2014, 12:32 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 14 2014, 12:32 AM
epriestley closed this revision.May 14 2014, 12:32 AM
epriestley updated this revision to Diff 21646.

Closed by commit rARCd484b6029505 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Diff 21646

View Options

src/lint/renderer/ArcanistLintCheckstyleXMLRenderer.php

Loading...
View Options

src/lint/renderer/ArcanistLintRenderer.php

Loading...
View Options

src/workflow/ArcanistLintWorkflow.php

Loading...
Phabricator · Built by Phacility