HomePhabricator

Be more strict with the type of `.arclint` properties.

Description

Be more strict with the type of .arclint properties.

Summary: Although this provides less context in terms of the error message (for example, Parameter has invalid type. Expected type 'optional regex|list<regex>', got type 'list<string>'.), I think that it is the right approach. I think that PhutilTypeSpec::checkMap should be improved such that additional context is provided in the exception message.

Test Plan: Ran arc lint. Modified .arclint to contain an invalid regex and ran arc lint again.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9089

Details

Provenance
joshuaspenceAuthored on
epriestleyCommitted on May 13 2014, 10:17 PM
epriestleyPushed on May 13 2014, 10:17 PM
Reviewer
Blessed Reviewers
Differential Revision
D9089: Be more strict with the type of `.arclint` properties.
Parents
rARC79285208c426: Don't prompt for patches when outputting lint results as XML.
Branches
Unknown
Tags
Unknown

Event Timeline