Merge branch "master" into "experimental"
Audit Required54697a4e7721
Actions

Description

Merge branch "master" into "experimental"

Details

Group Auditors

Provenance

epriestley	Authored on Jan 31 2019, 3:38 PM
epriestley	Pushed on Jan 31 2019, 3:38 PM

Parents

rARC25c2381959ac: Statically detect "continue" inside "switch"
rARC637c6584c6ea: (experimental) Work around a Windows escaping issue and security conecern in…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 21784
Build 29726: Run Core Tests

Event Timeline

epriestley committed rARC54697a4e7721: Merge branch "master" into "experimental" (authored by epriestley).Jan 31 2019, 3:38 PM

Herald added an auditor: Cowboy Commits. · View Herald TranscriptJan 31 2019, 3:38 PM

This commit now requires audit.Jan 31 2019, 3:38 PM

Harbormaster completed building B21784: rARC54697a4e7721: Merge branch "master" into "experimental".Jan 31 2019, 3:39 PM

Merged Changes

25c2381959ac Statically detect "continue" inside "switch"
Author
epriestley
Revisions
D19931: Statically detect "continue" inside "switch"
Browse Repository
Passed
No Audits
eb732555a71a Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule
Author
epriestley
Revisions
D19868: Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule
Browse Repository
Passed
No Audits
3534d2baca4b Small ReMarkup fix
Author
avivey
Revisions
D19794: Small ReMarkup fix
Browse Repository
Passed
No Audits
83661809e532 Work around a Windows escaping issue and security conecern in "hg cat --output .
Author
epriestley
Revisions
D19758: Work around a Windows escaping issue and security conecern in "hg cat --output ..."
Browse Repository
Passed
No Audits
2650e8627a20 Make the Arcanist comment remover less aggressive about stripping instructional…
Author
epriestley
Revisions
D19639: Make the Arcanist comment remover less aggressive about stripping instructional comments
Browse Repository
Passed
No Audits
30b7835c37b5 Allow `willLintPaths` and `didLintPaths` to be overridden
Author
joshuaspence
Revisions
D19630: Allow `willLintPaths` and `didLintPaths` to be overridden
Browse Repository
Passed
No Audits

Changes (12)

Path

Size

src/

__phutil_library_map__.php

configuration/

ArcanistConfiguration.php

lint/

linter/

ArcanistFutureLinter.php

xhpast/

rules/

ArcanistContinueInsideSwitchXHPASTLinterRule.php

ArcanistPHPCompatibilityXHPASTLinterRule.php

__tests__/

	ArcanistContinueInsideSwitchXHPASTLinterRuleTestCase.php
	ArcanistCurlyBraceArrayIndexXHPASTLinterRuleTestCase.php

continue-inside-switch

continue-inside-switch-1-valid.lint-test

continue-inside-switch-2-n.lint-test

continue-inside-switch-3-rewrite.lint-test

parser/

ArcanistCommentRemover.php

__tests__/

ArcanistCommentRemoverTestCase.php

rARC54697a4e7721

View Options

src/__phutil_library_map__.php

View Options

src/configuration/ArcanistConfiguration.php

View Options

src/lint/linter/ArcanistFutureLinter.php

View Options

src/lint/linter/xhpast/rules/ArcanistContinueInsideSwitchXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/ArcanistContinueInsideSwitchXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-1-valid.lint-test

View Options

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-2-n.lint-test

View Options

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-3-rewrite.lint-test

View Options

src/parser/ArcanistCommentRemover.php

View Options

src/parser/tests/ArcanistCommentRemoverTestCase.php

Merge branch "master" into "experimental"Audit Required54697a4e7721Actions

Description

Details

Event Timeline

Merged Changes

Changes (12)

rARC54697a4e7721

src/__phutil_library_map__.php

src/configuration/ArcanistConfiguration.php

src/lint/linter/ArcanistFutureLinter.php

src/lint/linter/xhpast/rules/ArcanistContinueInsideSwitchXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/ArcanistContinueInsideSwitchXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/continue-inside-switch/continue-inside-switch-1-valid.lint-test

src/lint/linter/xhpast/rules/__tests__/continue-inside-switch/continue-inside-switch-2-n.lint-test

src/lint/linter/xhpast/rules/__tests__/continue-inside-switch/continue-inside-switch-3-rewrite.lint-test

src/parser/ArcanistCommentRemover.php

src/parser/__tests__/ArcanistCommentRemoverTestCase.php

Merge branch "master" into "experimental"
Audit Required54697a4e7721
Actions

src/lint/linter/xhpast/rules/tests/ArcanistContinueInsideSwitchXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-1-valid.lint-test

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-2-n.lint-test

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-3-rewrite.lint-test

src/parser/tests/ArcanistCommentRemoverTestCase.php