Page MenuHomePhabricator

Statically detect "continue" inside "switch"
ClosedPublic

Authored by epriestley on Dec 22 2018, 1:44 PM.

Details

Summary

See 30 prior patches. This is a fatal in PHP7, let's just hunt these down.

Test Plan

Ran unit tests. See next diff for results.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Dec 22 2018, 1:44 PM
epriestley requested review of this revision.Dec 22 2018, 1:45 PM
epriestley updated this revision to Diff 47571.Dec 22 2018, 2:17 PM
  • More robust replacement logic.
amckinley accepted this revision.Dec 24 2018, 9:25 PM
This revision is now accepted and ready to land.Dec 24 2018, 9:25 PM
This revision was automatically updated to reflect the committed changes.