Differential D19931

Statically detect "continue" inside "switch"
ClosedPublic
Actions

Authored by epriestley on Dec 22 2018, 1:44 PM.

Details

Reviewers

amckinley

Commits

rARC97ddb9d5a1be: (stable) Promote 2018 Week 51
rARC25c2381959ac: Statically detect "continue" inside "switch"

Summary

See 30 prior patches. This is a fatal in PHP7, let's just hunt these down.

Test Plan

Ran unit tests. See next diff for results.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 22 2018, 1:44 PM

Harbormaster completed remote builds in B21422: Diff 47569.Dec 22 2018, 1:45 PM

epriestley requested review of this revision.Dec 22 2018, 1:45 PM

epriestley mentioned this in D19932: Fix the last remaining (?) continue inside switch.Dec 22 2018, 2:12 PM

More robust replacement logic.

Harbormaster completed remote builds in B21424: Diff 47571.Dec 22 2018, 2:17 PM

amckinley accepted this revision.Dec 24 2018, 9:25 PM

This revision is now accepted and ready to land.Dec 24 2018, 9:25 PM

Closed by commit rARC25c2381959ac: Statically detect "continue" inside "switch" (authored by epriestley). · Explain WhyDec 28 2018, 8:01 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rPe98ee73602ac: Fix the last remaining (?) continue inside switch.Dec 28 2018, 8:04 AM

epriestley mentioned this in D20039: Bring Duo MFA upstream.Jan 28 2019, 11:01 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

lint/

linter/

xhpast/

rules/

ArcanistContinueInsideSwitchXHPASTLinterRule.php

53 lines

__tests__/

ArcanistContinueInsideSwitchXHPASTLinterRuleTestCase.php

11 lines

continue-inside-switch/

continue-inside-switch-1-valid.lint-test

21 lines

continue-inside-switch-2-n.lint-test

24 lines

continue-inside-switch-3-rewrite.lint-test

26 lines

Diff 47577

View Options

src/__phutil_library_map__.php

View Options

src/lint/linter/xhpast/rules/ArcanistContinueInsideSwitchXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/ArcanistContinueInsideSwitchXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-1-valid.lint-test

View Options

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-2-n.lint-test

View Options

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-3-rewrite.lint-test

Statically detect "continue" inside "switch"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47577

src/__phutil_library_map__.php

src/lint/linter/xhpast/rules/ArcanistContinueInsideSwitchXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/ArcanistContinueInsideSwitchXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/continue-inside-switch/continue-inside-switch-1-valid.lint-test

src/lint/linter/xhpast/rules/__tests__/continue-inside-switch/continue-inside-switch-2-n.lint-test

src/lint/linter/xhpast/rules/__tests__/continue-inside-switch/continue-inside-switch-3-rewrite.lint-test

Statically detect "continue" inside "switch"
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/linter/xhpast/rules/tests/ArcanistContinueInsideSwitchXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-1-valid.lint-test

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-2-n.lint-test

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-3-rewrite.lint-test