Diffusion Arcanist 25c2381959ac

Statically detect "continue" inside "switch"
25c2381959ac
Actions

Description

Statically detect "continue" inside "switch"

Summary: See 30 prior patches. This is a fatal in PHP7, let's just hunt these down.

Test Plan: Ran unit tests. See next diff for results.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19931

Details

Provenance

epriestley	Authored on Dec 22 2018, 1:30 PM
epriestley	Pushed on Dec 28 2018, 8:01 AM

Reviewer

amckinley

Differential Revision

D19931: Statically detect "continue" inside "switch"

Parents

rARCeb732555a71a: Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule

Branches

Unknown

Tags

Unknown

Build Status

Buildable 21429
Build 29186: Run Core Tests

Event Timeline

epriestley committed rARC25c2381959ac: Statically detect "continue" inside "switch" (authored by epriestley).Dec 28 2018, 8:01 AM

Harbormaster completed building B21429: rARC25c2381959ac: Statically detect "continue" inside "switch".Dec 28 2018, 8:01 AM

epriestley mentioned this in 2018 Week 51 (End of Year).Dec 28 2018, 8:44 PM

epriestley mentioned this in 2019 Week 1 (Very Early January).Jan 5 2019, 12:51 AM

epriestley mentioned this in 2019 Week 2 (Early January).Jan 14 2019, 5:37 PM

epriestley mentioned this in 2019 Week 3 (Mid January).Jan 19 2019, 4:16 AM

epriestley mentioned this in 2019 Week 4 (Late January).Jan 29 2019, 2:35 AM

epriestley mentioned this in 2019 Week 5 (Very Early February).Feb 2 2019, 6:49 PM

epriestley mentioned this in 2019 Week 6 (Early February).Feb 9 2019, 2:55 PM

Changes (7)

Path

Size

src/

__phutil_library_map__.php

lint/

linter/

xhpast/

rules/

ArcanistContinueInsideSwitchXHPASTLinterRule.php

__tests__/

	ArcanistContinueInsideSwitchXHPASTLinterRuleTestCase.php
	ArcanistCurlyBraceArrayIndexXHPASTLinterRuleTestCase.php

continue-inside-switch

continue-inside-switch-1-valid.lint-test

continue-inside-switch-2-n.lint-test

continue-inside-switch-3-rewrite.lint-test

rARC25c2381959ac

View Options

src/__phutil_library_map__.php

View Options

src/lint/linter/xhpast/rules/ArcanistContinueInsideSwitchXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/ArcanistContinueInsideSwitchXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-1-valid.lint-test

View Options

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-2-n.lint-test

View Options

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-3-rewrite.lint-test

Statically detect "continue" inside "switch"25c2381959acActions

Description

Details

Event Timeline

Changes (7)

rARC25c2381959ac

src/__phutil_library_map__.php

src/lint/linter/xhpast/rules/ArcanistContinueInsideSwitchXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/ArcanistContinueInsideSwitchXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/continue-inside-switch/continue-inside-switch-1-valid.lint-test

src/lint/linter/xhpast/rules/__tests__/continue-inside-switch/continue-inside-switch-2-n.lint-test

src/lint/linter/xhpast/rules/__tests__/continue-inside-switch/continue-inside-switch-3-rewrite.lint-test

Statically detect "continue" inside "switch"
25c2381959ac
Actions

src/lint/linter/xhpast/rules/tests/ArcanistContinueInsideSwitchXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-1-valid.lint-test

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-2-n.lint-test

src/lint/linter/xhpast/rules/tests/continue-inside-switch/continue-inside-switch-3-rewrite.lint-test