HomePhabricator

Regnerate XHPAST with Bison 3.0.4

Authored by epriestley on Apr 29 2016, 1:23 PM.

Description

Regnerate XHPAST with Bison 3.0.4

Summary:
See rARC3ffed59. I think that test failure is some sort of weird parser generator bug in Bison 3.0.2 that appears to affect Ubuntu and OS X, at a minimum.

I don't immediately see what the acutal issue is, nor can I find anything suspicious in the changelog. However, I can reproduce the issue reliably locally (OS X).

If I do this:

$ git checkout master
$ git clean -df
$ ./scripts/build_xhpast.php

...I get test failures in arc.

If I do this:

$ git checkout bison304 # This change
$ git clean -df
$ ./scripts/build_xhpast.php

...I get clean tests.

The actual AST/parser look fine to me from careful inspection, too.

Test Plan: Added a now-passing unit test.

Reviewers: chad, richardvanvelzen

Reviewed By: richardvanvelzen

Differential Revision: https://secure.phabricator.com/D15820

Details

Committed
epriestleyApr 29 2016, 1:54 PM
Pushed
epriestleyApr 29 2016, 1:54 PM
Reviewer
richardvanvelzen
Differential Revision
D15820: Regnerate XHPAST with Bison 3.0.4
Parents
rPHUb20064a108f7: Add basic support for return type hints to xhpast
Branches
Unknown
Tags
Unknown
Build Status
Buildable 11983
Build 15073: Run Core Tests