Page MenuHomePhabricator

LightboxProject
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

That thing when you click on images or documents.

Recent Activity

Jul 9 2017

chad removed the image for Lightbox.
Jul 9 2017, 7:37 PM

Feb 13 2017

chad closed T12160: Lightbox asks user to log in if logged out as Resolved by committing rPf9163bf06539: Allow lightbox comments to be viewed logged out.
Feb 13 2017, 9:54 PM · Lightbox, Bug Report
chad added a revision to T12160: Lightbox asks user to log in if logged out: D17347: Allow lightbox comments to be viewed logged out.
Feb 13 2017, 9:49 PM · Lightbox, Bug Report
chad claimed T12160: Lightbox asks user to log in if logged out.
Feb 13 2017, 6:42 PM · Lightbox, Bug Report

Jan 27 2017

chad created T12160: Lightbox asks user to log in if logged out.
Jan 27 2017, 2:39 AM · Lightbox, Bug Report

Dec 29 2016

epriestley triaged T11171: When clicking an image in the comment edit modal, the image modal gets under the edit modal as Wishlist priority.

Kicking this out of Differential because this is reproducible in every application that allows you to edit comments.

Dec 29 2016, 6:09 PM · Lightbox, Bug Report
epriestley removed a project from T11171: When clicking an image in the comment edit modal, the image modal gets under the edit modal: Differential.
Dec 29 2016, 6:04 PM · Lightbox, Bug Report

Dec 12 2016

epriestley added a project to T2115: Back button support in Lightbox: Quicksand.
Dec 12 2016, 9:10 PM · Quicksand, Lightbox, Files

Dec 2 2016

chad added a revision to T3612: Lightbox v2: D16980: Add download link to embedded files.
Dec 2 2016, 8:59 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Dec 2 2016, 7:03 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Dec 2 2016, 7:02 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16979: Hide badges in phui-comment-panel.
Dec 2 2016, 7:01 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16978: Prevent double lightbox in lightbox comments.
Dec 2 2016, 6:53 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Dec 2 2016, 6:42 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Dec 2 2016, 6:42 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Dec 2 2016, 6:41 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16977: Make clicking on file icon in lightbox download file.
Dec 2 2016, 6:02 PM · Lightbox, Restricted Project, Files, Pholio

Nov 29 2016

chad updated the task description for T3612: Lightbox v2.
Nov 29 2016, 8:44 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16961: Make lightbox buttons more roundy.
Nov 29 2016, 7:01 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16959: Close lightbox when clicking on image-frame.
Nov 29 2016, 5:21 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Nov 29 2016, 1:33 AM · Lightbox, Restricted Project, Files, Pholio
chad added a comment to T3612: Lightbox v2.

https://mozilla.github.io/pdf.js/

Nov 29 2016, 1:30 AM · Lightbox, Restricted Project, Files, Pholio
cspeckmim added a comment to T3612: Lightbox v2.

Ah I totally missed the F1234 being in the lightbox already. And I did figure that using 3rd party code to render PDF would be out of the question. I don't really know what the current state of PDFs in browsers is so I had my project manager hat on for that question~

Nov 29 2016, 1:27 AM · Lightbox, Restricted Project, Files, Pholio
chad added a comment to T3612: Lightbox v2.
  • I don't think that's a lightbox bug, just a general blog bug.
  • To be fixed.
  • If it's native? We won't be adding third party code for this.
  • We added F1234 to the header of the lightbox for resharing.
Nov 29 2016, 1:24 AM · Lightbox, Restricted Project, Files, Pholio
cspeckmim added a comment to T3612: Lightbox v2.

Woo came here from the blog. Just a few notes so far:

  1. The lightbox on the blog doesn't seem to show anything under the Comment pane even though I should be logged in (to admin.phacility.com). Or is the blog.phacility.com completely isolated/separate? These were errors I got in Firefox console, which I don't get when using lightbox on this instance.
    • Error: JX.$('phabricator-help-menu') call matched no nodes.
    • XHR POST https://blog.phacility.com/file/thread/PHID-FILE-3ittlvgojn2326tbg22z/ [HTTP/1.1 404 Not Found 338ms]
  2. I'm very used to "click anywhere that isn't the image to close the lightbox" behavior. My personal preference would be to maintain that when clicking on any empty space outside the image/file. I think this is due to where my mouse is located when I click the image (towards center of screen usually) and where I would go to click to close (in most cases just slightly down vs. top right corner). But then I use a trackball so...
  3. Is PDF preview considered? PDFs were specifically mentioned in the blog so I have to ask~
  4. (Maybe not totally related) Some way to easily reference the same file instance from different areas. Most users I see will continue to drag/drop the same file in different areas and not use the same file reference object {F1234} - which I'm assuming would mean two separate comment chains, etc. Maybe somewhere in the lightbox listing the tasks/diffs/etc. where the file is referenced would help understanding. Or a way to view/copy the file remarkup to be used elsewhere. Or maybe this is all T11543.
Nov 29 2016, 1:07 AM · Lightbox, Restricted Project, Files, Pholio

Nov 28 2016

chad added a revision to T3612: Lightbox v2: D16957: Use proper file icons in lightbox.
Nov 28 2016, 7:16 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Nov 28 2016, 7:13 PM · Lightbox, Restricted Project, Files, Pholio
epriestley added a comment to T3612: Lightbox v2.

(To answer your question more directly: yeah, no way to do pht() with variables in Javascript. We can build that without TOO much trouble, but I'd like to wait for a really good use case first.)

Nov 28 2016, 2:44 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16951: Remove english from lightbox javascript.
Nov 28 2016, 1:59 AM · Lightbox, Restricted Project, Files, Pholio
epriestley added a comment to T3612: Lightbox v2.

I'd say just get rid of it, or render "X / Y" without pht()?

Nov 28 2016, 1:14 AM · Lightbox, Restricted Project, Files, Pholio

Nov 27 2016

chad added a comment to T3612: Lightbox v2.

Doesn't look possible to do "Image x of y" in current phtize from JS... Worth adding or just changing the language? I don't have any great ideas on updating the language. Unsure x of y is useful though.

Nov 27 2016, 11:09 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16950: Prettier file embeds.
Nov 27 2016, 11:08 PM · Lightbox, Restricted Project, Files, Pholio

Nov 25 2016

chad updated the task description for T3612: Lightbox v2.
Nov 25 2016, 10:21 PM · Lightbox, Restricted Project, Files, Pholio

Nov 23 2016

chad updated the task description for T3612: Lightbox v2.
Nov 23 2016, 1:46 AM · Lightbox, Restricted Project, Files, Pholio

Nov 22 2016

chad added a revision to T3612: Lightbox v2: D16918: Restyle remarkup file links.
Nov 22 2016, 9:20 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Nov 22 2016, 7:30 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16917: Allow commenting on non-viewable lightbox files.
Nov 22 2016, 7:29 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Nov 22 2016, 4:20 AM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16907: Ajax commenting on lightbox images.
Nov 22 2016, 4:19 AM · Lightbox, Restricted Project, Files, Pholio

Nov 18 2016

chad updated the task description for T3612: Lightbox v2.
Nov 18 2016, 6:11 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Nov 18 2016, 6:10 PM · Lightbox, Restricted Project, Files, Pholio
chad renamed T3612: Lightbox v2 from Implement a standard 'image commenting' UI into Phabricator to Lightbox v2.
Nov 18 2016, 6:10 PM · Lightbox, Restricted Project, Files, Pholio
chad added a project to T3612: Lightbox v2: Lightbox.
Nov 18 2016, 6:08 PM · Lightbox, Restricted Project, Files, Pholio
chad added a project to T11171: When clicking an image in the comment edit modal, the image modal gets under the edit modal: Lightbox.
Nov 18 2016, 6:08 PM · Lightbox, Bug Report
chad added a project to T9274: Lightbox cycles through both on-page images and Conpherence sidebar images: Lightbox.
Nov 18 2016, 6:07 PM · Lightbox, Conpherence
chad added a project to T2115: Back button support in Lightbox: Lightbox.
Nov 18 2016, 6:07 PM · Quicksand, Lightbox, Files
chad created Lightbox.
Nov 18 2016, 6:06 PM