HomePhabricator

fail `arc diff` if second lfs push errors

Description

fail arc diff if second lfs push errors

Summary:
We are having issues where people run out of file descriptors and the first git push will succeed, but the
second one will not. We'd like the diff to not be created in this case as it leads to weird behavior like our tests
running against 0 changed files.

Test Plan: none

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D21471

Details

Provenance
ptarjanAuthored on Sep 23 2020, 8:23 PM
ptarjanPushed on Mon, Sep 28, 11:21 PM
Reviewer
Blessed Reviewers
Differential Revision
D21471: fail `arc diff` if second lfs push errors
Parents
rARCa716c4e55fdd: In "phutil_passthru()", "resolve()" the future rather than calling "execute()"…
Branches
Unknown
Tags
Unknown
Build Status
Buildable 24925
Build 34386: Run Core Tests