Page MenuHomePhabricator

fail `arc diff` if second lfs push errors
ClosedPublic

Authored by ptarjan on Sep 23 2020, 8:26 PM.

Details

Summary

We are having issues where people run out of file descriptors and the first git push will succeed, but the
second one will not. We'd like the diff to not be created in this case as it leads to weird behavior like our tests
running against 0 changed files.

Test Plan

none

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.