Page MenuHomePhabricator

joshma (Joshua Ma)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 6 2012, 9:18 AM (611 w, 6 d)
Availability
Available

Recent Activity

Feb 12 2017

joshma added a comment to T12173: Support Buildkite as a Harbormaster target.

Any thoughts on deeper integration with Phabricator? Namely:

  • Reporting back which tests passed/failed
  • Reporting back code coverage (I guess right now it's part of reporting tests via the API, but I'd be happy even if it's merged under 1 dummy test case)
Feb 12 2017, 2:38 AM · Harbormaster, Phacility
joshma added a comment to T12172: Better color scheme for diffs.

:/ colors are hard. From my end, I'm very happy with what I ended up doing in Stylish (and this conversation helped, thank you) so it's not as pressing for me anymore. But LMK if there's anything I can help test out.

Feb 12 2017, 2:31 AM · Accessibility, Feature Request
joshma added a comment to T12172: Better color scheme for diffs.

Based on http://enchroma.com/test/result/medium-protan/?completed=1&summary=moderate+protan&axis=3.11&exta=87.34&extb=4.85&lcs=5.69, I have protanomaly (TIL!)

Feb 12 2017, 2:16 AM · Accessibility, Feature Request
joshma added a comment to T12172: Better color scheme for diffs.

So I took another look today. Given that the syntax colors are hard to change, looking only at the 4 bg colors I realized that the main change that would help is if td.new-full just used td.new's background color instead (#eaffea). I think it's because:

Feb 12 2017, 2:07 AM · Accessibility, Feature Request

Feb 8 2017

joshma added a comment to T12172: Better color scheme for diffs.

(by the way @epriestley I haven't forgotten; some things have come up but I'll try to get back to you this weekend!)

Feb 8 2017, 5:09 PM · Accessibility, Feature Request

Jan 31 2017

joshma added a comment to T12172: Better color scheme for diffs.

Better - are keywords/classnames red? I think for me reds are duller, so they look very similar to the plain black text - brightening that would help.

Jan 31 2017, 1:21 AM · Accessibility, Feature Request
joshma added a comment to T12172: Better color scheme for diffs.

😺 😺 😺

Jan 31 2017, 12:59 AM · Accessibility, Feature Request
joshma added a comment to T12172: Better color scheme for diffs.

:( Maybe this is more isolated than I thought - I can probably make do with a stylish extension for now (if the blue/orange mode doesn't work). For what it's worth I find github's colors pretty readable, seems like a useful reference to me.

Jan 31 2017, 12:48 AM · Accessibility, Feature Request
joshma added a comment to T12172: Better color scheme for diffs.

Versions:

phabricator a4f8aff2a2e41e5853488689c9d79ee425482fb9 (Sat, Jan 14)
arcanist ade25facfdf22aed1c1e20fed3e58e60c0be3c2b (Thu, Jan 5)
phutil 9d85dfab0f532d50c2343719e92d574a4827341b (Thu, Jan 12)
Jan 31 2017, 12:36 AM · Accessibility, Feature Request
joshma created T12172: Better color scheme for diffs.
Jan 31 2017, 12:13 AM · Accessibility, Feature Request

Jan 9 2017

joshma added a comment to T9186: CloudFront configuration is more involved than the documentation implies.

FWIW this affected us as well, we switched from cloudflare back to cloudfront and hit this snag. The default settings do not forward Host header, we had to add that ourselves. Didn't need to change anything else, though - it seems that cloudfront performs loose SSL validation and is OK with the certificate/host mismatch. (Maybe it at least requires the host to match the origin domain - not sure.)

Jan 9 2017, 5:11 PM · Setup

Dec 14 2016

joshma added Q526: Does ELB/ALB need extra configuration to proxy git ssh? (Answer 488).
Dec 14 2016, 6:27 PM

Dec 1 2016

joshma added a comment to Q526: Does ELB/ALB need extra configuration to proxy git ssh?.

Thank you! I'll do that and report back.

Dec 1 2016, 2:16 AM
joshma updated Q526: Does ELB/ALB need extra configuration to proxy git ssh? from to Does ELB/ALB need extra configuration to proxy git ssh?.
Dec 1 2016, 1:51 AM

Oct 17 2016

joshma updated the task description for T11768: Show diff statistics (lines changed).
Oct 17 2016, 10:47 PM · Feature Request
joshma created T11768: Show diff statistics (lines changed).
Oct 17 2016, 10:46 PM · Feature Request

Jun 28 2016

joshma created T11227: Support including files by shebang in .arclint.
Jun 28 2016, 8:22 PM · Restricted Project, Lint, Feature Request

May 24 2016

joshma created T11022: Implement a `current-milestone-of(project)` tokenizer function.
May 24 2016, 2:01 AM · Projects, Feature Request

May 3 2016

joshma added a comment to T10911: Surface unit test results in diff.

Got it, thanks again.

May 3 2016, 5:02 PM · Feature Request
joshma added a comment to T10911: Surface unit test results in diff.

Just to wrap this up - the phabricator plugin for jenkins does actually report it correctly. The unit tests in our diffs don't show up unless tests are failing, so as a minor request it'd be nice to show *something* (maybe just test summary - # tests, time it took) even if all tests are passing.

May 3 2016, 3:54 PM · Feature Request

May 2 2016

joshma added a comment to T10911: Surface unit test results in diff.

Oh wow, that is nice haha. I will follow up with the plugin author instead, thanks.

May 2 2016, 11:30 PM · Feature Request
joshma renamed T10911: Surface unit test results in diff from Surface unit tests in diff to Surface unit test results in diff.
May 2 2016, 11:21 PM · Feature Request
joshma created T10911: Surface unit test results in diff.
May 2 2016, 11:21 PM · Feature Request

Apr 14 2016

joshma added a comment to T7907: Ability to filter/search Maniphest tasks based on Workboard column position.

We're currently using columns as lightweight "subprojects" - i.e. our Bugs project has a FIXME column for higher-priority bugs. Would the recommendation here be to just use a subproject?

Apr 14 2016, 7:55 PM · Maniphest, Workboards

Feb 17 2016

joshma added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

👍 worked fine for me, thank you!

Feb 17 2016, 3:01 AM · Projects (v3)
joshma added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

Ah cool, I think that'll work, noticing this:

UPDATE `phabricator_maniphest`.`maniphest_task` SET points = 2 WHERE id = 4130;
UPDATE `phabricator_maniphest`.`maniphest_task` SET points = 2 WHERE id = 4129;
HAS POINTSHAS POINTSUPDATE `phabricator_maniphest`.`maniphest_task` SET points = 0 WHERE id = 4201;
HAS POINTSHAS POINTSHAS POINTSHAS POINTS
Feb 17 2016, 2:55 AM · Projects (v3)
joshma added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

We're using the wikimedia sprint extension, which adds a isdc:sprint:storypoints field - upon running ./copy_points.php --field isdc:sprint:storypoints, we get

[2016-02-16 18:46:22] EXCEPTION: (PhutilArgumentUsageException) Field "isdc:sprint:storypoints" is not an "int" field, and can not be migrated. at [<phabricator>/copy_points.php:62]
arcanist(head=master, ref.master=fcc11b3a2781), phabricator(head=master, ref.master=608fcdd9dd70, custom=2), phutil(head=master, ref.master=f43291e99d36), sprint(head=master, ref.master=802afc636035)
Feb 17 2016, 2:47 AM · Projects (v3)

Feb 12 2016

joshma added a comment to T4427: Add formal task points.

A use case: "I want to see how well we're sizing points, show me all 4 point tasks"

Feb 12 2016, 2:31 AM · Wikimedia, Maniphest, Workboards

Feb 10 2016

joshma added a comment to D14286: Add a "Build with CircleCI" build step.

got it, will send them a ping :)

Feb 10 2016, 10:49 PM
joshma added a comment to D14286: Add a "Build with CircleCI" build step.

out of curiosity, are this diff and D14288 on hold indefinitely? we're hitting some growing pains and would love to have circle ci results in diffs, so debating if we should wait a month or just go ahead and roll our own hacky hooks

Feb 10 2016, 10:15 PM

Apr 17 2015

joshma updated subscribers of T7851: UI sporadically jumps down when hovering over things.

Awesome, thanks @chad

Apr 17 2015, 11:29 PM · Differential
joshma updated the task description for T7851: UI sporadically jumps down when hovering over things.
Apr 17 2015, 11:21 PM · Differential
joshma created T7851: UI sporadically jumps down when hovering over things.
Apr 17 2015, 11:20 PM · Differential

May 28 2014

joshma added a comment to T5186: Cannot edit projects.

I get a duplicate entry error when changing case (e.g. project name -> Project Name)

May 28 2014, 12:29 AM · Projects
joshma awarded rP70ec8052fddc: Fix issue when editing a project with no secondary hash tags a Mountain of Wealth token.
May 28 2014, 12:22 AM