Page MenuHomePhabricator
Feed All Stories

Apr 16 2020

epriestley added a revision to T13511: Allow extensions to define new document fields (like "title:") in Ferret search: Unknown Object (Differential Revision).
Apr 16 2020, 5:31 PM · Search
epriestley added a revision to T13501: Improve search index normalization of "é" and other characters with variants or multiple representations: Unknown Object (Differential Revision).
Apr 16 2020, 4:38 PM · Search
epriestley added a revision to T13501: Improve search index normalization of "é" and other characters with variants or multiple representations: Unknown Object (Differential Revision).
Apr 16 2020, 4:32 PM · Search
epriestley added a revision to T13511: Allow extensions to define new document fields (like "title:") in Ferret search: Unknown Object (Differential Revision).
Apr 16 2020, 3:05 PM · Search
epriestley added a parent task for T13503: Index Paste documents in Ferret: T13511: Allow extensions to define new document fields (like "title:") in Ferret search.
Apr 16 2020, 3:05 PM · Search, Paste
epriestley added a parent task for T13501: Improve search index normalization of "é" and other characters with variants or multiple representations: T13511: Allow extensions to define new document fields (like "title:") in Ferret search.
Apr 16 2020, 3:05 PM · Search
epriestley added subtasks for T13511: Allow extensions to define new document fields (like "title:") in Ferret search: T13509: Support "field present" and "field absent" operators in Ferret, T13503: Index Paste documents in Ferret, T13501: Improve search index normalization of "é" and other characters with variants or multiple representations.
Apr 16 2020, 3:05 PM · Search
epriestley added a parent task for T13509: Support "field present" and "field absent" operators in Ferret: T13511: Allow extensions to define new document fields (like "title:") in Ferret search.
Apr 16 2020, 3:05 PM · Search
epriestley triaged T13511: Allow extensions to define new document fields (like "title:") in Ferret search as Normal priority.
Apr 16 2020, 3:04 PM · Search
epriestley added a comment to T13501: Improve search index normalization of "é" and other characters with variants or multiple representations.

Getting through the ngram index alone isn't good enough, because LIKE operators against utf8mb4_unicode_ci treat combining accents as separate characters:

Apr 16 2020, 2:59 PM · Search
epriestley added a comment to T13501: Improve search index normalization of "é" and other characters with variants or multiple representations.

Normalizer requires intl which I'm hesitant to add a dependency on.

Apr 16 2020, 2:00 PM · Search
codeblock updated codeblock.
Apr 16 2020, 3:37 AM
codeblock updated codeblock.
Apr 16 2020, 3:37 AM

Apr 15 2020

epriestley closed T13507: Compress Conduit client requests as Resolved.

One possible improvement remains here: in streaming mode, HTTPSFuture will not "Accept-Encoding: gzip" and can not inflate responses. Today, this only applies to arc download.

Apr 15 2020, 6:58 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 15 2020, 6:35 PM · Performance, Conduit
epriestley triaged T13510: Migration "20160223.paste.fileedges.php" fails after the "Paste" database was renamed as Wishlist priority.
Apr 15 2020, 6:05 PM · Paste, Installing & Upgrading
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 15 2020, 12:28 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 15 2020, 12:16 PM · Performance, Conduit
0xseantasker added a comment to T2495: Improve whitespace expansion of tab literals.

I get the sense that most of this discussion is around diffs, but we've been having issues with the default size of 8 showing in code blocks in Phriction causing more wrapping than we would like.

Apr 15 2020, 1:49 AM · Restricted Project, FreeBSD, Diffusion, Differential

Apr 14 2020

epriestley added a comment to T13507: Compress Conduit client requests.

There's also one minor related concern in PHI1638 that I want to take care of here, since it's adjacent.

Apr 14 2020, 11:52 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 14 2020, 11:47 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 14 2020, 11:45 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 14 2020, 11:21 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 14 2020, 9:52 PM · Performance, Conduit
epriestley added a comment to T13507: Compress Conduit client requests.

In fairness, "SetInputFilter DEFLATE" is documented as uniquely opinionated, if you catch this box and read between the lines a little bit:

Apr 14 2020, 9:45 PM · Performance, Conduit
epriestley added a comment to T13507: Compress Conduit client requests.

A grand aventure in PHI1679 led to identifying the Apache "SetInputFilter DEFLATE" directive as a problem with implementing compression.

Apr 14 2020, 9:40 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 14 2020, 9:25 PM · Performance, Conduit
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 14 2020, 7:47 PM · Arcanist
epriestley closed T13509: Support "field present" and "field absent" operators in Ferret as Resolved.

This appears to be working properly, now.

Apr 14 2020, 6:19 PM · Search
epriestley added a comment to T13509: Support "field present" and "field absent" operators in Ferret.

Query parsing of certain unusual or ambiguous inputs has changed slightly.

Apr 14 2020, 5:31 PM · Search
epriestley added a revision to T13509: Support "field present" and "field absent" operators in Ferret: Unknown Object (Differential Revision).
Apr 14 2020, 5:31 PM · Search
epriestley added a revision to T13509: Support "field present" and "field absent" operators in Ferret: Unknown Object (Differential Revision).
Apr 14 2020, 5:23 PM · Search
epriestley added a revision to T13509: Support "field present" and "field absent" operators in Ferret: Unknown Object (Differential Revision).
Apr 14 2020, 5:22 PM · Search
epriestley added a revision to T13509: Support "field present" and "field absent" operators in Ferret: Unknown Object (Differential Revision).
Apr 14 2020, 5:18 PM · Search
epriestley added a revision to T13509: Support "field present" and "field absent" operators in Ferret: Unknown Object (Differential Revision).
Apr 14 2020, 5:03 PM · Search
epriestley added a revision to T13509: Support "field present" and "field absent" operators in Ferret: Unknown Object (Differential Revision).
Apr 14 2020, 4:56 PM · Search
epriestley added a revision to T13509: Support "field present" and "field absent" operators in Ferret: Unknown Object (Differential Revision).
Apr 14 2020, 4:52 PM · Search
epriestley triaged T13509: Support "field present" and "field absent" operators in Ferret as Low priority.
Apr 14 2020, 4:48 PM · Search

Apr 13 2020

epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 13 2020, 10:02 PM · Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 13 2020, 9:50 PM · Arcanist
epriestley created P2134 Command-Line Input.
Apr 13 2020, 9:13 PM
epriestley created P2133 Command-Line Input.
Apr 13 2020, 9:12 PM
epriestley created P2132 Command-Line Input.
Apr 13 2020, 9:11 PM
epriestley created P2131 Command-Line Input.
Apr 13 2020, 9:10 PM
epriestley created P2130 Command-Line Input.
Apr 13 2020, 9:10 PM
epriestley created P2129 Command-Line Input.
Apr 13 2020, 9:10 PM
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Apr 13 2020, 9:09 PM · Arcanist, Installing & Upgrading
epriestley created P2128 (An Untitled Masterwork).
Apr 13 2020, 9:08 PM
epriestley created P2127 (An Untitled Masterwork).
Apr 13 2020, 9:07 PM
epriestley created P2126 (An Untitled Masterwork).
Apr 13 2020, 9:07 PM
epriestley created P2125 (An Untitled Masterwork).
Apr 13 2020, 9:07 PM
epriestley created P2124 (An Untitled Masterwork).
Apr 13 2020, 9:03 PM
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Apr 13 2020, 8:42 PM · Arcanist, Installing & Upgrading
epriestley closed T13203: Arcanist Wilds Patch Notes (Ongoing) as Resolved.

wilds and experimental have mostly collapsed together into master, and this is survived by T13488.

Apr 13 2020, 7:36 PM · Arcanist, Plans
epriestley closed T13203: Arcanist Wilds Patch Notes (Ongoing), a subtask of T13098: Plans: Arcanist toolsets and extensions, as Resolved.
Apr 13 2020, 7:36 PM · Arcanist, Plans
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 13 2020, 7:00 PM · Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 13 2020, 6:39 PM · Arcanist
epriestley added a comment to T13490: Upgrade all "classic" Arcanist workflows to Toolsets.

These are in better shape now:

Apr 13 2020, 6:18 PM · Arcanist
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Apr 13 2020, 1:09 PM · Arcanist, Installing & Upgrading
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 13 2020, 1:08 PM · Arcanist
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Apr 13 2020, 1:06 PM · Arcanist, Installing & Upgrading
epriestley added a comment to T13490: Upgrade all "classic" Arcanist workflows to Toolsets.

I think I'm going to remove these workflows outright:

Apr 13 2020, 12:52 PM · Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 13 2020, 12:25 PM · Arcanist
epriestley closed T7616: Arcanist to be able to access site requiring client side SSL certificate as Wontfix.

We currently have no interest in this from customers, so I don't plan to pursue it. If customer interest arises, there's a plausible pathway forward.

Apr 13 2020, 11:49 AM · Arcanist, libphutil
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 13 2020, 11:31 AM · Arcanist

Apr 12 2020

epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 12 2020, 11:15 PM · Arcanist
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Apr 12 2020, 11:12 PM · Arcanist, Installing & Upgrading
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Apr 12 2020, 11:09 PM · Arcanist, Installing & Upgrading
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Apr 12 2020, 10:02 PM · Arcanist, Installing & Upgrading
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Apr 12 2020, 9:40 PM · Arcanist, Installing & Upgrading
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 12 2020, 9:15 PM · Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 12 2020, 7:34 PM · Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 12 2020, 6:04 PM · Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 12 2020, 5:38 PM · Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 12 2020, 3:05 PM · Arcanist

Apr 11 2020

epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 11 2020, 11:57 PM · Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 11 2020, 10:52 PM · Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 11 2020, 10:38 PM · Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 11 2020, 10:32 PM · Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 11 2020, 10:29 PM · Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 11 2020, 8:18 PM · Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 11 2020, 5:40 PM · Arcanist
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Apr 11 2020, 5:17 PM · Arcanist, Installing & Upgrading
epriestley added a comment to T13490: Upgrade all "classic" Arcanist workflows to Toolsets.

A general issue with config is that I'd like to modularize config sources, so you can read config from a service or something if you really want, or define a custom configuration source for other Toolset commands like phage. Previously, sources were hard-coded.

Apr 11 2020, 3:26 PM · Arcanist
epriestley added a comment to T13490: Upgrade all "classic" Arcanist workflows to Toolsets.

T11968 was a very deep hole, but I think I've now dug my way out of it. With those changes, these workflows are now modern:

Apr 11 2020, 2:59 PM · Arcanist
epriestley awarded T11968: Decide the fate of FutureGraph a Hungry Hippo token.
Apr 11 2020, 2:41 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley closed T11968: Decide the fate of FutureGraph as Resolved.

"FutureGraph" is dead. Long live "HardpointEngine".

Apr 11 2020, 2:41 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley closed T11968: Decide the fate of FutureGraph, a subtask of T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching, as Resolved.
Apr 11 2020, 2:41 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11968: Decide the fate of FutureGraph: Unknown Object (Differential Revision).
Apr 11 2020, 1:44 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11968: Decide the fate of FutureGraph: Unknown Object (Differential Revision).
Apr 11 2020, 1:40 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist

Apr 10 2020

epriestley triaged T13508: In Chrome, the menu bar hover animation can cycle very rapidly if you put your cursor exactly on the bottom as Wishlist priority.
Apr 10 2020, 2:55 PM · Design
epriestley added a revision to T11968: Decide the fate of FutureGraph: Unknown Object (Differential Revision).
Apr 10 2020, 2:51 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley abandoned D3357: GitHub-style punchcards.

No current plans to pursue this upstream.

Apr 10 2020, 2:32 PM
epriestley added a revision to T11968: Decide the fate of FutureGraph: Unknown Object (Differential Revision).
Apr 10 2020, 1:06 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a comment to T11968: Decide the fate of FutureGraph.

Generators can't "return" until PHP 7:

Apr 10 2020, 11:43 AM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11968: Decide the fate of FutureGraph: Unknown Object (Differential Revision).
Apr 10 2020, 11:39 AM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist

Apr 9 2020

epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 9 2020, 8:27 PM · Performance, Conduit
epriestley added a comment to T13507: Compress Conduit client requests.

PHP has a setting called post_max_size. If a POST request is larger than this size, PHP does not populate $_POST or $_FILES.

Apr 9 2020, 8:22 PM · Performance, Conduit

Apr 8 2020

epriestley added a revision to T11968: Decide the fate of FutureGraph: Unknown Object (Differential Revision).
Apr 8 2020, 7:37 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 8 2020, 7:37 PM · Arcanist