Page MenuHomePhabricator
Feed All Stories

Apr 25 2022

epriestley added a revision to T13658: How to rebrand Phabricator: D21789: Remove product literal strings in "pht()", part 23.
Apr 25 2022, 11:24 PM
epriestley added a comment to D21788: Remove product literal strings in "pht()", part 22.

This list had one or two strings in Phragment and Releeph but I'm just going to throw those in a hole.

Apr 25 2022, 11:21 PM
epriestley retitled D21788: Remove product literal strings in "pht()", part 22 from Remove product literal strings in "pht()", part 21 to Remove product literal strings in "pht()", part 22.
Apr 25 2022, 11:20 PM
epriestley retitled D21787: Remove product literal strings in "pht()", part 21 from Remove product literal strings in "pht()", part 20 to Remove product literal strings in "pht()", part 21.
Apr 25 2022, 11:20 PM
epriestley requested review of D21788: Remove product literal strings in "pht()", part 22.
Apr 25 2022, 11:19 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21788: Remove product literal strings in "pht()", part 22.
Apr 25 2022, 11:19 PM
cspeckmim abandoned D21712: Trying out removing "Phabricator" from some user-visible text.

馃憖

Apr 25 2022, 11:17 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21787: Remove product literal strings in "pht()", part 21.
Apr 25 2022, 11:16 PM
epriestley requested review of D21787: Remove product literal strings in "pht()", part 21.
Apr 25 2022, 11:16 PM
epriestley updated the diff for D21786: Remove product literal strings in "pht()", part 20.
  • Fix a PHP 8.1 "strlen(null)" issue.
Apr 25 2022, 11:13 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21786: Remove product literal strings in "pht()", part 20.
Apr 25 2022, 11:12 PM
epriestley requested review of D21786: Remove product literal strings in "pht()", part 20.
Apr 25 2022, 11:12 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21785: Remove product literal strings in "pht()", part 19.
Apr 25 2022, 11:08 PM
epriestley requested review of D21785: Remove product literal strings in "pht()", part 19.
Apr 25 2022, 11:08 PM
epriestley requested review of D21784: Remove product literal strings in "pht()", part 18.
Apr 25 2022, 11:05 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21784: Remove product literal strings in "pht()", part 18.
Apr 25 2022, 11:05 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21783: Remove product literal strings in "pht()", part 17.
Apr 25 2022, 9:50 PM
epriestley requested review of D21783: Remove product literal strings in "pht()", part 17.
Apr 25 2022, 9:50 PM
epriestley requested review of D21782: Remove product literal strings in "pht()", part 16.
Apr 25 2022, 9:44 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21782: Remove product literal strings in "pht()", part 16.
Apr 25 2022, 9:44 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21781: Remove product literal strings in "pht()", part 15.
Apr 25 2022, 9:39 PM
epriestley requested review of D21781: Remove product literal strings in "pht()", part 15.
Apr 25 2022, 9:39 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21780: Remove product literal strings in "pht()", part 14.
Apr 25 2022, 9:34 PM
epriestley requested review of D21780: Remove product literal strings in "pht()", part 14.
Apr 25 2022, 9:34 PM
epriestley requested review of D21779: Remove product literal strings in "pht()", part 13.
Apr 25 2022, 9:28 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21779: Remove product literal strings in "pht()", part 13.
Apr 25 2022, 9:28 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21778: Remove product literal strings in "pht()", part 12.
Apr 25 2022, 9:21 PM
epriestley requested review of D21778: Remove product literal strings in "pht()", part 12.
Apr 25 2022, 9:21 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21777: Remove product literal strings in "pht()", part 11.
Apr 25 2022, 9:14 PM
epriestley requested review of D21777: Remove product literal strings in "pht()", part 11.
Apr 25 2022, 9:14 PM
epriestley requested review of D21776: Catch more product names in "pht()", and replace newly matched Arcanist product names.
Apr 25 2022, 8:04 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21776: Catch more product names in "pht()", and replace newly matched Arcanist product names.
Apr 25 2022, 8:04 PM
epriestley closed D21775: Fix a PHP 8.1 string strictness issue in repositories.
Apr 25 2022, 7:30 PM
epriestley committed rPadcc063242e5: Fix a PHP 8.1 string strictness issue in repositories (authored by epriestley).
Fix a PHP 8.1 string strictness issue in repositories
Apr 25 2022, 7:30 PM
epriestley requested review of D21775: Fix a PHP 8.1 string strictness issue in repositories.
Apr 25 2022, 7:28 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21775: Fix a PHP 8.1 string strictness issue in repositories.
Apr 25 2022, 7:28 PMInfrastructure
epriestley closed D21774: Remove product literal strings in "pht()", part 10.
Apr 25 2022, 7:23 PM
epriestley closed D21773: Remove product literal strings in "pht()", part 9.
Apr 25 2022, 7:23 PM
epriestley closed D21772: Remove product literal strings in "pht()", part 8.
Apr 25 2022, 7:23 PM
epriestley committed rP57469db22e5a: Remove product literal strings in "pht()", part 9 (authored by epriestley).
Remove product literal strings in "pht()", part 9
Apr 25 2022, 7:23 PM
epriestley closed D21771: Remove product literal strings in "pht()", part 7.
Apr 25 2022, 7:23 PM
epriestley committed rP297c0bbfcfcd: Remove product literal strings in "pht()", part 10 (authored by epriestley).
Remove product literal strings in "pht()", part 10
Apr 25 2022, 7:23 PM
epriestley committed rP4d3f0dc7c727: Remove product literal strings in "pht()", part 8 (authored by epriestley).
Remove product literal strings in "pht()", part 8
Apr 25 2022, 7:23 PM
epriestley committed rP67795a46ebfd: Remove product literal strings in "pht()", part 7 (authored by epriestley).
Remove product literal strings in "pht()", part 7
Apr 25 2022, 7:23 PM
epriestley closed D21770: Remove product literal strings in "pht()", part 6.
Apr 25 2022, 7:22 PM
epriestley committed rPb3557796fe65: Remove product literal strings in "pht()", part 6 (authored by epriestley).
Remove product literal strings in "pht()", part 6
Apr 25 2022, 7:22 PM
epriestley committed rPad880491e8d6: Remove product literal strings in "pht()", part 5 (authored by epriestley).
Remove product literal strings in "pht()", part 5
Apr 25 2022, 7:22 PM
epriestley closed D21769: Remove product literal strings in "pht()", part 5.
Apr 25 2022, 7:22 PM
epriestley committed rPd69da878d283: Remove product literal strings in "pht()", part 4 (authored by epriestley).
Remove product literal strings in "pht()", part 4
Apr 25 2022, 7:22 PM
epriestley closed D21768: Remove product literal strings in "pht()", part 4.
Apr 25 2022, 7:22 PM
epriestley closed D21767: Remove product literal strings in "pht()", part 3.
Apr 25 2022, 7:22 PM
epriestley closed D21766: Remove product literal strings in "pht()", part 2.
Apr 25 2022, 7:22 PM
epriestley committed rPb8b392481fd1: Remove product literal strings in "pht()", part 2 (authored by epriestley).
Remove product literal strings in "pht()", part 2
Apr 25 2022, 7:22 PM
epriestley committed rPb1b3fe0ff0a6: Remove product literal strings in "pht()", part 3 (authored by epriestley).
Remove product literal strings in "pht()", part 3
Apr 25 2022, 7:22 PM
epriestley closed D21765: Remove product literal strings in "pht()", part 1.
Apr 25 2022, 7:22 PM
epriestley committed rP3e82ab5adb73: Remove product literal strings in "pht()", part 1 (authored by epriestley).
Remove product literal strings in "pht()", part 1
Apr 25 2022, 7:22 PM
epriestley closed D21764: Remove all product name literals in "pht()" in Arcanist.
Apr 25 2022, 7:21 PM
epriestley committed rARC93cf13cdb963: Remove all product name literals in "pht()" in Arcanist (authored by epriestley).
Remove all product name literals in "pht()" in Arcanist
Apr 25 2022, 7:21 PM
epriestley closed D21763: Add a "product name literal in pht()" linter.
Apr 25 2022, 7:21 PM
epriestley committed rARCa33aeb3c36c2: Add a "product name literal in pht()" linter (authored by epriestley).
Add a "product name literal in pht()" linter
Apr 25 2022, 7:21 PM
epriestley updated the diff for D21764: Remove all product name literals in "pht()" in Arcanist.
  • One additional PHP 8.1 fix for float/int precision.
Apr 25 2022, 7:20 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21774: Remove product literal strings in "pht()", part 10.
Apr 25 2022, 7:19 PM
epriestley requested review of D21774: Remove product literal strings in "pht()", part 10.
Apr 25 2022, 7:19 PM
epriestley retitled D21773: Remove product literal strings in "pht()", part 9 from Remove product literal strings in "pht()", part 8 to Remove product literal strings in "pht()", part 9.
Apr 25 2022, 7:18 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21773: Remove product literal strings in "pht()", part 9.
Apr 25 2022, 7:16 PM
epriestley requested review of D21773: Remove product literal strings in "pht()", part 9.
Apr 25 2022, 7:16 PM
epriestley updated the diff for D21772: Remove product literal strings in "pht()", part 8.
  • Additional PHP 8.1 "strlen(null)" fix.
Apr 25 2022, 7:10 PM
epriestley requested review of D21772: Remove product literal strings in "pht()", part 8.
Apr 25 2022, 7:09 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21772: Remove product literal strings in "pht()", part 8.
Apr 25 2022, 7:09 PM
epriestley updated the test plan for D21771: Remove product literal strings in "pht()", part 7.
Apr 25 2022, 7:03 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21771: Remove product literal strings in "pht()", part 7.
Apr 25 2022, 7:03 PM
epriestley requested review of D21771: Remove product literal strings in "pht()", part 7.
Apr 25 2022, 7:03 PM
epriestley updated the diff for D21764: Remove all product name literals in "pht()" in Arcanist.
  • Additional PHP 8.1 "strlen(null)" fix.
Apr 25 2022, 6:57 PM
epriestley updated the diff for D21770: Remove product literal strings in "pht()", part 6.
  • Additional PHP 8.1 "strlen(null)" fixes.
Apr 25 2022, 6:57 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21770: Remove product literal strings in "pht()", part 6.
Apr 25 2022, 6:37 PM
epriestley requested review of D21770: Remove product literal strings in "pht()", part 6.
Apr 25 2022, 6:37 PM
epriestley updated the diff for D21769: Remove product literal strings in "pht()", part 5.
  • Fix some PHP 8.1 "strlen(null)" stuff.
Apr 25 2022, 6:29 PM
epriestley requested review of D21769: Remove product literal strings in "pht()", part 5.
Apr 25 2022, 6:24 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21769: Remove product literal strings in "pht()", part 5.
Apr 25 2022, 6:24 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21768: Remove product literal strings in "pht()", part 4.
Apr 25 2022, 6:19 PM
epriestley requested review of D21768: Remove product literal strings in "pht()", part 4.
Apr 25 2022, 6:19 PM
epriestley added a comment to T13658: How to rebrand Phabricator.

Some general guidelines I'm following here:

Apr 25 2022, 5:56 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21767: Remove product literal strings in "pht()", part 3.
Apr 25 2022, 5:46 PM
epriestley requested review of D21767: Remove product literal strings in "pht()", part 3.
Apr 25 2022, 5:46 PM
epriestley requested review of D21766: Remove product literal strings in "pht()", part 2.
Apr 25 2022, 5:30 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21766: Remove product literal strings in "pht()", part 2.
Apr 25 2022, 5:30 PM
epriestley requested review of D21765: Remove product literal strings in "pht()", part 1.
Apr 25 2022, 5:18 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21765: Remove product literal strings in "pht()", part 1.
Apr 25 2022, 5:18 PM
epriestley added a comment to T13658: How to rebrand Phabricator.

I don't want to get embroiled in this too much, but:

Apr 25 2022, 5:04 PM
epriestley requested review of D21764: Remove all product name literals in "pht()" in Arcanist.
Apr 25 2022, 4:44 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21764: Remove all product name literals in "pht()" in Arcanist.
Apr 25 2022, 4:44 PM
epriestley added a revision to T13658: How to rebrand Phabricator: D21763: Add a "product name literal in pht()" linter.
Apr 25 2022, 4:41 PM
epriestley requested review of D21763: Add a "product name literal in pht()" linter.
Apr 25 2022, 4:41 PM

Apr 23 2022

epriestley added a comment to T13675: Can Arcanist plausibly be compiled into a binary?.

Is the purpose of implementing introspection of libraries to allow for building native components that would get picked up and auto-loaded by arcanist?

Apr 23 2022, 10:08 PMArcanist
cspeckmim added a comment to T13675: Can Arcanist plausibly be compiled into a binary?.

I find this very intriguing.

Phabricator would benefit from having access certain services (full-text search, full-codebase search, repository graph storage) that very likely aren't practical to write in PHP

Is the purpose of implementing introspection of libraries to allow for building native components that would get picked up and auto-loaded by arcanist?

Apr 23 2022, 4:14 PMArcanist

Apr 22 2022

cspeckmim added a comment to T13667: Landing a mercurial revision which has no changes causes errors on the revision page as well as history viewing.

Browsing Diffusion (namely, loading a file while the published changeset is head, and trying to Skip past commit):

I couldn't immediately reproduce this; it's also probably a bit of a messy fix.

I'll plan to investigate further if possible. I believe in this case the repository was running in observed mode rather than hosted in case that might be a factor.

Apr 22 2022, 2:23 AMArcanist, Mercurial
cspeckmim awarded T13675: Can Arcanist plausibly be compiled into a binary? a Manufacturing Defect? token.
Apr 22 2022, 2:08 AMArcanist

Apr 21 2022

epriestley added a comment to T13675: Can Arcanist plausibly be compiled into a binary?.

How can PHP be built statically? How hard is this?

Apr 21 2022, 11:01 PMArcanist
epriestley added a comment to T13675: Can Arcanist plausibly be compiled into a binary?.
$ cat random.c
int get_random_number() {
  return 5;
}
$ gcc -c -o random.o random.c
$ gcc -shared -o random.so random.o
Apr 21 2022, 10:23 PMArcanist
epriestley triaged T13675: Can Arcanist plausibly be compiled into a binary? as Normal priority.
Apr 21 2022, 8:24 PMArcanist