Page MenuHomePhabricator

Catch more product names in "pht()", and replace newly matched Arcanist product names
ClosedPublic

Authored by epriestley on Apr 25 2022, 8:04 PM.
Tags
None
Referenced Files
F17860812: D21776.id51932.diff
Sun, Jul 27, 10:11 PM
F17843060: D21776.diff
Sun, Jul 27, 12:26 AM
F17674695: D21776.diff
Sun, Jul 13, 7:28 AM
F17657455: D21776.diff
Sat, Jul 12, 12:18 PM
Unknown Object (File)
Jun 27 2025, 3:40 PM
Unknown Object (File)
Jun 7 2025, 2:22 AM
Unknown Object (File)
May 31 2025, 4:06 AM
Unknown Object (File)
May 30 2025, 9:32 AM
Subscribers
None

Details

Summary

Ref T13658. The lint rule called "getStringLiteralValue()", which produces string literals for fewer nodes than "evalStatic()".

Switch to "evalStatic()", then fix new warnings.

Test Plan

This test plan is non-exhaustive.

  • Ran "arc lint --everything --output summary" to generate new warnings.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 11:46 PM
This revision was automatically updated to reflect the committed changes.