Page MenuHomePhabricator

Catch more product names in "pht()", and replace newly matched Arcanist product names
ClosedPublic

Authored by epriestley on Mon, Apr 25, 8:04 PM.

Details

Summary

Ref T13658. The lint rule called "getStringLiteralValue()", which produces string literals for fewer nodes than "evalStatic()".

Switch to "evalStatic()", then fix new warnings.

Test Plan

This test plan is non-exhaustive.

  • Ran "arc lint --everything --output summary" to generate new warnings.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Apr 25, 11:46 PM
This revision was automatically updated to reflect the committed changes.