Page MenuHomePhabricator

Remove product literal strings in "pht()", part 1

Authored by epriestley on Apr 25 2022, 5:18 PM.
Referenced Files
F12186518: D21765.id51901.diff
Sat, Sep 16, 9:45 PM
Sat, Sep 16, 4:12 PM
F12185990: D21765.diff
Sat, Sep 16, 3:59 PM
F12165463: D21765.diff
Thu, Sep 7, 12:17 AM
F12134360: D21765.diff
Aug 25 2023, 4:37 AM
F12131996: D21765.diff
Aug 24 2023, 4:32 AM
Unknown Object (File)
Aug 17 2023, 5:32 AM
Unknown Object (File)
Aug 16 2023, 7:58 PM
Restricted Owners Package



Ref T13658. I used the linter in D21763 to identify these and split them into arbitrary groups of 10 files.

Test Plan

This test plan is non-exhaustive, because some of these strings are difficult to reach.

  • Looked at "Create Service" in Almanac.
  • Used "bin/auth" to go through a one-time auth workflow (not all related strings can be hit on a single workflow).
  • Started the "Generate Keypair" worfklow in "SSH Public Keys".

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 25 2022, 5:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:22 PM
This revision was automatically updated to reflect the committed changes.