Page MenuHomePhabricator

Remove product literal strings in "pht()", part 1
ClosedPublic

Authored by epriestley on Apr 25 2022, 5:18 PM.
Tags
None
Referenced Files
F19931602: D21765.diff
Fri, Apr 10, 1:33 AM
F19914435: D21765.id51884.diff
Fri, Apr 3, 11:14 AM
F19908823: D21765.id.diff
Wed, Apr 1, 10:10 PM
F19846526: D21765.id51901.diff
Mar 12 2026, 12:17 PM
F19824735: D21765.id51884.diff
Mar 8 2026, 3:14 AM
F19813278: D21765.diff
Mar 4 2026, 8:35 AM
F19508365: D21765.id51901.diff
Jan 10 2026, 3:38 AM
F19508364: D21765.id51884.diff
Jan 10 2026, 3:38 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13658. I used the linter in D21763 to identify these and split them into arbitrary groups of 10 files.

Test Plan

This test plan is non-exhaustive, because some of these strings are difficult to reach.

  • Looked at "Create Service" in Almanac.
  • Used "bin/auth" to go through a one-time auth workflow (not all related strings can be hit on a single workflow).
  • Started the "Generate Keypair" worfklow in "SSH Public Keys".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 25 2022, 5:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:22 PM
This revision was automatically updated to reflect the committed changes.