Page MenuHomePhabricator

Remove product literal strings in "pht()", part 1
ClosedPublic

Authored by epriestley on Apr 25 2022, 5:18 PM.
Tags
None
Referenced Files
F15455338: D21765.diff
Sat, Mar 29, 11:36 PM
F15443171: D21765.id51901.diff
Thu, Mar 27, 2:50 AM
F15438878: D21765.id51884.diff
Wed, Mar 26, 4:16 AM
F15432008: D21765.id.diff
Mon, Mar 24, 3:46 PM
F15430494: D21765.id51884.diff
Mon, Mar 24, 7:54 AM
F15425904: D21765.diff
Sun, Mar 23, 6:36 AM
F15420193: D21765.id51884.diff
Fri, Mar 21, 12:05 PM
F15397576: D21765.diff
Sun, Mar 16, 9:10 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13658. I used the linter in D21763 to identify these and split them into arbitrary groups of 10 files.

Test Plan

This test plan is non-exhaustive, because some of these strings are difficult to reach.

  • Looked at "Create Service" in Almanac.
  • Used "bin/auth" to go through a one-time auth workflow (not all related strings can be hit on a single workflow).
  • Started the "Generate Keypair" worfklow in "SSH Public Keys".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 25 2022, 5:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:22 PM
This revision was automatically updated to reflect the committed changes.