Page MenuHomePhabricator

Remove product literal strings in "pht()", part 1
ClosedPublic

Authored by epriestley on Apr 25 2022, 5:18 PM.
Tags
None
Referenced Files
F14714251: D21765.id51884.diff
Fri, Jan 17, 5:09 PM
Unknown Object (File)
Tue, Jan 14, 12:05 AM
Unknown Object (File)
Wed, Jan 8, 7:28 AM
Unknown Object (File)
Thu, Dec 26, 4:58 PM
Unknown Object (File)
Tue, Dec 24, 6:27 AM
Unknown Object (File)
Mon, Dec 23, 8:25 AM
Unknown Object (File)
Dec 18 2024, 12:58 AM
Unknown Object (File)
Dec 16 2024, 11:15 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13658. I used the linter in D21763 to identify these and split them into arbitrary groups of 10 files.

Test Plan

This test plan is non-exhaustive, because some of these strings are difficult to reach.

  • Looked at "Create Service" in Almanac.
  • Used "bin/auth" to go through a one-time auth workflow (not all related strings can be hit on a single workflow).
  • Started the "Generate Keypair" worfklow in "SSH Public Keys".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 25 2022, 5:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:22 PM
This revision was automatically updated to reflect the committed changes.