Page MenuHomePhabricator

Remove product literal strings in "pht()", part 1
ClosedPublic

Authored by epriestley on Apr 25 2022, 5:18 PM.
Tags
None
Referenced Files
F18772461: D21765.id.diff
Thu, Oct 9, 2:42 AM
F18766963: D21765.id51884.diff
Tue, Oct 7, 7:41 PM
F18766944: D21765.diff
Tue, Oct 7, 7:34 PM
F18766403: D21765.id51901.diff
Tue, Oct 7, 4:32 PM
F18763071: D21765.diff
Mon, Oct 6, 10:28 PM
F18717556: D21765.id.diff
Mon, Sep 29, 2:08 PM
F18705116: D21765.id.diff
Sun, Sep 28, 10:11 AM
F18703973: D21765.diff
Sun, Sep 28, 5:46 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13658. I used the linter in D21763 to identify these and split them into arbitrary groups of 10 files.

Test Plan

This test plan is non-exhaustive, because some of these strings are difficult to reach.

  • Looked at "Create Service" in Almanac.
  • Used "bin/auth" to go through a one-time auth workflow (not all related strings can be hit on a single workflow).
  • Started the "Generate Keypair" worfklow in "SSH Public Keys".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 25 2022, 5:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:22 PM
This revision was automatically updated to reflect the committed changes.