Page MenuHomePhabricator

Remove product literal strings in "pht()", part 1
ClosedPublic

Authored by epriestley on Apr 25 2022, 5:18 PM.
Tags
None
Referenced Files
F14309403: D21765.diff
Wed, Dec 18, 12:58 AM
Unknown Object (File)
Mon, Dec 16, 11:15 AM
Unknown Object (File)
Thu, Dec 12, 9:09 PM
Unknown Object (File)
Thu, Dec 12, 11:27 AM
Unknown Object (File)
Wed, Dec 11, 3:49 PM
Unknown Object (File)
Fri, Dec 6, 10:47 PM
Unknown Object (File)
Fri, Dec 6, 6:21 PM
Unknown Object (File)
Fri, Dec 6, 1:26 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13658. I used the linter in D21763 to identify these and split them into arbitrary groups of 10 files.

Test Plan

This test plan is non-exhaustive, because some of these strings are difficult to reach.

  • Looked at "Create Service" in Almanac.
  • Used "bin/auth" to go through a one-time auth workflow (not all related strings can be hit on a single workflow).
  • Started the "Generate Keypair" worfklow in "SSH Public Keys".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 25 2022, 5:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:22 PM
This revision was automatically updated to reflect the committed changes.