Page MenuHomePhabricator

Remove product literal strings in "pht()", part 1
ClosedPublic

Authored by epriestley on Apr 25 2022, 5:18 PM.
Tags
None
Referenced Files
F19508365: D21765.id51901.diff
Sat, Jan 10, 3:38 AM
F19508364: D21765.id51884.diff
Sat, Jan 10, 3:38 AM
F19508363: D21765.id.diff
Sat, Jan 10, 3:38 AM
F19468971: D21765.diff
Sun, Jan 4, 1:30 PM
F19073269: D21765.diff
Dec 1 2025, 1:38 AM
F18939202: D21765.id.diff
Nov 11 2025, 6:11 AM
F18939119: D21765.diff
Nov 11 2025, 6:01 AM
F18924157: D21765.id.diff
Nov 9 2025, 5:24 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13658. I used the linter in D21763 to identify these and split them into arbitrary groups of 10 files.

Test Plan

This test plan is non-exhaustive, because some of these strings are difficult to reach.

  • Looked at "Create Service" in Almanac.
  • Used "bin/auth" to go through a one-time auth workflow (not all related strings can be hit on a single workflow).
  • Started the "Generate Keypair" worfklow in "SSH Public Keys".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 25 2022, 5:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 7:22 PM
This revision was automatically updated to reflect the committed changes.