Page MenuHomePhabricator
Feed Advanced Search

Apr 12 2018

epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 12 2018, 9:50 PM · Plans
epriestley updated the task description for T13120: Plans: 2018 Week 15 Bonus Content.
Apr 12 2018, 9:47 PM · Plans
epriestley added a revision to T10883: Allow repository cluster nodes to be read-only: Unknown Object (Differential Revision).
Apr 12 2018, 9:09 PM · Restricted Project, Diffusion, Clusters
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 12 2018, 9:09 PM · Plans
epriestley added a revision to T10883: Allow repository cluster nodes to be read-only: Unknown Object (Differential Revision).
Apr 12 2018, 9:00 PM · Restricted Project, Diffusion, Clusters
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 12 2018, 8:59 PM · Plans
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 12 2018, 8:38 PM · Plans
epriestley added a revision to T10883: Allow repository cluster nodes to be read-only: Unknown Object (Differential Revision).
Apr 12 2018, 8:38 PM · Restricted Project, Diffusion, Clusters
epriestley triaged T13122: "Continue on missing fields" in Bulk Edit allows removal of required fields as Normal priority.
Apr 12 2018, 6:42 PM · ApplicationEditor
epriestley added a comment to T3626: Detection of language for some file types isn't good.

Yeah, this is a combination of a bulk editor bug (which lets you delete task titles) and legacy compatibility code for transaction title rendering (which treats null -> anything transactions as "created this thing.").

Apr 12 2018, 3:30 PM · Customer Impact, Restricted Project, Differential
epriestley renamed T3626: Detection of language for some file types isn't good from to Detection of language for some file types isn't good.
Apr 12 2018, 2:30 PM · Customer Impact, Restricted Project, Differential
epriestley renamed T6816: In diffs, when a file is both generated code and no changes were made, "Show File Contents" does not behave as expected from to In diffs, when a file is both generated code and no changes were made, "Show File Contents" does not behave as expected.
Apr 12 2018, 2:29 PM · Restricted Project, Differential
epriestley renamed T1101: Allow Show Raw File for updated added files from to Allow Show Raw File for updated added files.
Apr 12 2018, 2:29 PM · Differential
epriestley renamed T3626: Detection of language for some file types isn't good from Detection of language for some file types isn't good to .
Apr 12 2018, 2:28 PM · Customer Impact, Restricted Project, Differential
epriestley renamed T6816: In diffs, when a file is both generated code and no changes were made, "Show File Contents" does not behave as expected from In diffs, when a file is both generated code and no changes were made, "Show File Contents" does not behave as expected to .
Apr 12 2018, 2:28 PM · Restricted Project, Differential
epriestley renamed T1101: Allow Show Raw File for updated added files from Allow Show Raw File for updated added files to .
Apr 12 2018, 2:28 PM · Differential
epriestley added a comment to T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands.

I'm leaning toward:

Apr 12 2018, 12:11 AM · Phacility, Ops
epriestley triaged T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands as Low priority.
Apr 12 2018, 12:08 AM · Phacility, Ops

Apr 11 2018

epriestley updated the task description for T13081: Quicksand breaks the back button after a reload, et al.
Apr 11 2018, 9:48 PM · Quicksand
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 11 2018, 9:47 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 11 2018, 9:30 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 11 2018, 9:15 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 11 2018, 8:45 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to P2090 (An Untitled Masterwork).

Hmm, I can't reproduce the issue. Here's pre-comment:

Apr 11 2018, 7:09 PM
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
  • Source view rendering in Paste has a missing background color.
Apr 11 2018, 7:06 PM · Plans, Files, Differential, Diffusion
epriestley closed T12414: Implement Almanac edit endpoints in Conduit, a subtask of T12218: Reduce the operational cost of a larger Phacility cluster, as Resolved.
Apr 11 2018, 5:54 PM · Ops, Phacility
epriestley closed T12414: Implement Almanac edit endpoints in Conduit as Resolved.

I think that's pretty much everything. There will be a little followup work in T10883 and maybe T13076 / T13120.

Apr 11 2018, 5:54 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 11 2018, 4:44 PM · Plans
epriestley updated the task description for T13120: Plans: 2018 Week 15 Bonus Content.
Apr 11 2018, 4:44 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 11 2018, 4:28 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 11 2018, 4:28 PM · Plans
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 11 2018, 3:41 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 11 2018, 3:41 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 11 2018, 2:17 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 11 2018, 2:17 PM · Conduit, Almanac, Ops, Phacility
epriestley added a comment to T12414: Implement Almanac edit endpoints in Conduit.

Everything here should pretty much work except:

Apr 11 2018, 2:08 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 11 2018, 1:40 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 11 2018, 1:40 PM · Plans

Apr 10 2018

epriestley added a comment to T12999: Replace cluster magnetic volumes with SSD volumes.

I think all the T13076 stuff is blocked on me for now unless you're feeling especially ambitious about trying to get bin/host download working on 2GB+ files (T12907 / D19011). That might be a bit of a mess of a task though since I think I have a lot of secret cURL knowledge from over the years that is only somewhat-documented in HTTPSFuture.

Apr 10 2018, 10:47 PM · Phacility, Ops
epriestley added a comment to T12999: Replace cluster magnetic volumes with SSD volumes.

Backups should run continuously (starting 12 hours after the instance launches, then every 24 hours after that):

Apr 10 2018, 7:30 PM · Phacility, Ops
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 7:22 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 7:22 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 6:41 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 6:41 PM · Plans
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 6:22 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 6:22 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 6:19 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 6:19 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 6:03 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 6:03 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 5:10 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 5:10 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 5:08 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 5:08 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 3:43 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 3:43 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 3:27 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 3:27 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 2:24 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 1:38 PM · Conduit, Almanac, Ops, Phacility
epriestley added a comment to T12414: Implement Almanac edit endpoints in Conduit.

Before I can get rid of AlmanacDeviceTransaction::TYPE_INTERFACE, we have two meaningful callsites in rSERVICES and one unit test in rSAAS to clean up.

Apr 10 2018, 1:30 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 1:28 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 1:28 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Restricted Differential Revision.
Apr 10 2018, 1:17 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Restricted Differential Revision.
Apr 10 2018, 1:17 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 12:57 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 12:57 PM · Plans
epriestley added a comment to T12414: Implement Almanac edit endpoints in Conduit.

There's a bit of a mess with AlmanacInterface and AlmanacDevice. Currently, AlmanacInterface does not use transactions, and is edited purely as a side effect of INTERFACE transactions applying to AlmanacDevice. I'm going to change how this works so that AlmanacInterface is a normal transactional object and can use the same rules and infrastructure as everything else.

Apr 10 2018, 12:34 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 12:21 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 12:21 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 12:15 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 12:15 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 10 2018, 11:51 AM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 10 2018, 11:51 AM · Plans
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

I think "run weekly with the deploy" already works pretty well for normal log rotation with logs on local disk, and in a perfect world logs would be buffering on disk only briefly before being sent over the network to dedicated log service so we wouldn't need cron there either.

Apr 10 2018, 11:36 AM · Plans, Ops, Infrastructure, Phacility

Apr 9 2018

epriestley added a revision to T13118: Code block headers wrap in the dumbest way in Safari: Unknown Object (Differential Revision).
Apr 9 2018, 11:34 PM · Remarkup
epriestley added a comment to T13118: Code block headers wrap in the dumbest way in Safari.

yikes

Apr 9 2018, 10:05 PM · Remarkup
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 9 2018, 9:20 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 9 2018, 9:20 PM · Plans
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 9 2018, 9:10 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 9 2018, 9:10 PM · Plans
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

Yeah, I think "solve it forever" is probably "first-party Sentry-like application", this just seems like a problem that should have a 15-minute "solve it for now" solution in the form of something that gives us "a thing that looks like a disk but never fills up" that will hold for a year or two until we build "Phentry".

Apr 9 2018, 9:01 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

I believe there are zero or nearly-zero actionable errors in the log today and that if we had a perfect Sentry-like system it wouldn't actually help us identify or fix any errors -- we'd just ignore it after a week like we currently ignore all the other production error logs.

Apr 9 2018, 7:49 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

The "logs fill up disks" problem is more "sudden bursts of unusual error/activity that cause log rates to increase 1000x+ fill up disks", not "logs don't rotate / normal log volumes fill up disks". Most logs do already rotate today, I think with the exception of the aphlict log being a bit of a weird case, maybe.

Apr 9 2018, 7:14 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

phage tail <some-instance-name> <some-log-type>

Apr 9 2018, 7:10 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

Possibly something dumb like "mount an EFS volume on /mnt/logs/ on every host" is another AWS-only approach. That feels really dumb but maybe it's only somewhat dumb?

Apr 9 2018, 6:35 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

I'm fine with CloudWatch logs, I didn't realize it had a logging thing. I'm currently not terribly warm on investing a ton in CloudWatch alarms or log analysis, but if we can get logs reliably streaming into some storage service so they can't fill up the disk I think that's quite valuable on its own. We can always replace that with something we control directly in the future if we want to invest more here. I can't imagine ever really caring about old logs no matter what happens in the future.

Apr 9 2018, 6:30 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T12847: A Pathway Towards Private Clusters.

In the modern era: I think we generally understand what private clusters will look like now, but I'd like to take a much more iterative approach to getting there than we have in the past. I had this concern above (circa June 2017):

Apr 9 2018, 6:03 PM · Plans, Ops, Phacility
epriestley added a revision to T12414: Implement Almanac edit endpoints in Conduit: Unknown Object (Differential Revision).
Apr 9 2018, 5:11 PM · Conduit, Almanac, Ops, Phacility
epriestley added a revision to T13120: Plans: 2018 Week 15 Bonus Content: Unknown Object (Differential Revision).
Apr 9 2018, 5:11 PM · Plans
epriestley added a comment to T13120: Plans: 2018 Week 15 Bonus Content.

Multiple installs would like API access to edit Almanac bindings.

Apr 9 2018, 4:48 PM · Plans
epriestley moved T13120: Plans: 2018 Week 15 Bonus Content from Backlog to Soon on the Plans board.
Apr 9 2018, 4:11 PM · Plans
epriestley moved T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions from Backlog to Soon on the Plans board.
Apr 9 2018, 4:11 PM · Plans, Differential
epriestley closed T13015: Improve color readability for change age in Diffusion blame view as Resolved by committing Restricted Diffusion Commit.
Apr 9 2018, 1:11 PM · Design, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 9 2018, 1:09 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13015: Improve color readability for change age in Diffusion blame view: Restricted Differential Revision.
Apr 9 2018, 1:09 PM · Design, Diffusion
epriestley added a comment to T13015: Improve color readability for change age in Diffusion blame view.

This feels a bit like a return to the era of "epriestley design", but I think it's an improvement overall:

Apr 9 2018, 1:05 PM · Design, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 9 2018, 12:40 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 9 2018, 12:26 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 9 2018, 12:20 PM · Plans, Files, Differential, Diffusion