@epriestley, is this code review going to be accepted? Or do you know the status of it? Is there something that I can do to help it get accepted? This is something that I was looking at extending myself but then I found this code review.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 7 2014
Jun 7 2014
May 27 2014
May 27 2014
bwinterton closed Restricted Maniphest Task, a subtask of T3569: Make Phrequent somewhat usable, as Resolved.
May 16 2014
May 16 2014
bwinterton added a comment to D9147: Added a popup to both start and end times with Phrequent allowing the user to edit their start/end times. Also added a field for notes on the stop time.
I am sorry, I completely missed that one. $verb_formatted can also be removed. Sorry that I did not catch that.
bwinterton updated the diff for D9147: Added a popup to both start and end times with Phrequent allowing the user to edit their start/end times. Also added a field for notes on the stop time.
- Fixed trailing whitespace
bwinterton updated the diff for D9147: Added a popup to both start and end times with Phrequent allowing the user to edit their start/end times. Also added a field for notes on the stop time.
- Made changes requested by epriestley and added checking for invalid dates
bwinterton added a comment to D9147: Added a popup to both start and end times with Phrequent allowing the user to edit their start/end times. Also added a field for notes on the stop time.
Thanks for your help! I will get those changes made right away.
May 15 2014
May 15 2014
bwinterton added a task to D9147: Added a popup to both start and end times with Phrequent allowing the user to edit their start/end times. Also added a field for notes on the stop time: Unknown Object (Maniphest Task).
Apr 9 2014
Apr 9 2014
bwinterton updated the diff for D8735: Changed the rendering of the `priority` column color based on the `priorityColor` property.
- Changed the priority_accepted_colors to web_to_terminal_colors map and mapped all colors found in the palette
bwinterton added a comment to D8735: Changed the rendering of the `priority` column color based on the `priorityColor` property.
Actually I like that idea a lot. I can see how terminalColor could be overkill. But I like the web color map. Would you like to to just map the default configuration colors, or would you like me to map basic ones as well? I will get to work on that right now.
bwinterton added a comment to D8734: Add a priorityColor property to the maniphest conduit endpoint.
This diff is supporting D8735
bwinterton added a comment to D8735: Changed the rendering of the `priority` column color based on the `priorityColor` property.
Currently this does not allow for users to define any colors other than the basics:
- magenta
- red
- yellow
- green
- blue
- cyan
and have them show up correctly in the terminal. Another option (which I feel would be better and would also allow us to continue supporting the default configuration) would be to add a terminalColor property to the maniphest.priorities config and allowing the user to define a color that will be displayed on phabricator and a color that arc tasks will display.
bwinterton retitled D8735: Changed the rendering of the `priority` column color based on the `priorityColor` property from to Changed the rendering of the `priority` column color based on the `priorityColor` property.
bwinterton retitled D8734: Add a priorityColor property to the maniphest conduit endpoint from to Add a priorityColor property to the maniphest conduit endpoint.
bwinterton updated the diff for D8732: Changed checking for a closed task in `arc tasks` to look for the isClosed property instead of a non-empty status.
Added the changes requested by epriestley.
Now arc tasks shows the actual human-readable status and a green bar for open or red bar for closed. Also, if there is a newer version of arc using an older version of phabricator, the status column will not be displayed so that we do not have any errors thrown.
bwinterton added a comment to D8731: Added isClosed property to maniphest conduit endpoint in order to fix an issue with arcanist when displaying tasks.
Here are the fixes. I am happy to do it. I am excited to continue contributing to these projects. My team and I are going to begin using phabricator and arcanist so there are improvements that I will hopefully be able to make as we find things that we would like improved.
bwinterton updated the diff for D8731: Added isClosed property to maniphest conduit endpoint in order to fix an issue with arcanist when displaying tasks.
Update to change the base commit for the diff
bwinterton updated the diff for D8731: Added isClosed property to maniphest conduit endpoint in order to fix an issue with arcanist when displaying tasks.
Added a statusName property as well which will be used by arc tasks in D8732.
bwinterton added a comment to D8731: Added isClosed property to maniphest conduit endpoint in order to fix an issue with arcanist when displaying tasks.
I'm sorry I hadn't seen the task. I should have checked first. I think that adding statusName would definitely be of use. That could also be potentially used in the arc tasks display instead of Open/Closed don't you think? I think that would be much more informative and we can leave a green bar signifying open and red signifying closed.
bwinterton retitled D8732: Changed checking for a closed task in `arc tasks` to look for the isClosed property instead of a non-empty status from to Changed checking for a closed task in `arc tasks` to look for the isClosed property instead of a non-empty status.
bwinterton retitled D8731: Added isClosed property to maniphest conduit endpoint in order to fix an issue with arcanist when displaying tasks from to Added isClosed property to maniphest conduit endpoint in order to fix an issue with arcanist when displaying tasks.