Arcanist is currently displaying all tasks as closed when invoking arc tasks.
This is because arcanist is setting the display to closed if there is anything in the status property. Adding an isClosed property will allow arcanist to properly display open/closed status on tasks by checking against the isClosed property. The isClosed property will be set according to the closed property that is set on each status in maniphest.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4744: `arc tasks` probably needs an update for user-configurable statuses
- Commits
- Restricted Diffusion Commit
rPdffbbaf0a65b: Added isClosed property to maniphest conduit endpoint in order to fix an issue…
Invoke the conduit maniphest.info method on any task and insure that:
- The isClosed property is included in the properties
- that it is set properly according to the statuses set for maniphest.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
A small bite of context in T4744. Offhand, I'd guess that adding statusName might also be useful? The status field just has the status constant (like open), not the human-readable name (like Open), right?
If that seems sensible, you should be able to pull it with:
'statusName' => ManiphestTaskStatus:;getTaskStatusName($task->getStatus()),
We probably need to adjust maniphest.query slightly too, but that can be a separate diff.
Comment Actions
I'm sorry I hadn't seen the task. I should have checked first. I think that adding statusName would definitely be of use. That could also be potentially used in the arc tasks display instead of Open/Closed don't you think? I think that would be much more informative and we can leave a green bar signifying open and red signifying closed.
And you are correct about the status field showing the constant versus the human readable.
I can go ahead and add that functionality in right now (that was where I was headed with this anyways). Would you like me to add that change to this diff or would you like me to make another?
Also, I can look into maniphest.query and see if we will need to tweak anything there.
Comment Actions
Yeah, let's do this:
- add statusName to this diff (just update the existing revision);
- update D8732 to make use of the new statusName column.
We can land those, and then look into the query stuff separately.
Comment Actions
(I have to log off for the night, but I'll take a look at the updates tomorrow if you've had a chance to get through them by then. Thanks for these fixes!)
Comment Actions
Here are the fixes. I am happy to do it. I am excited to continue contributing to these projects. My team and I are going to begin using phabricator and arcanist so there are improvements that I will hopefully be able to make as we find things that we would like improved.
Also, sorry about the change in the diff, I accidentally based it off of one of my local commits.