Page MenuHomePhabricator

Add a priorityColor property to the maniphest conduit endpoint
ClosedPublic

Authored by bwinterton on Apr 9 2014, 6:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 4:07 PM
Unknown Object (File)
Wed, Apr 17, 3:11 PM
Unknown Object (File)
Tue, Apr 16, 1:37 PM
Unknown Object (File)
Tue, Apr 16, 1:21 AM
Unknown Object (File)
Mon, Apr 15, 10:45 AM
Unknown Object (File)
Mon, Apr 15, 3:38 AM
Unknown Object (File)
Mon, Apr 15, 3:38 AM
Unknown Object (File)
Mon, Apr 15, 3:20 AM
Subscribers

Details

Summary

I added a getTaskPriorityColor function to the ManiphestTaskPriority class which returns the color set in the maniphest config for the given priority.

This is in preparation for a change to arcanist which will allow it to display the priority color (if it is a supported color) upon running arc tasks.

Fixed some linting issues

Test Plan

Invoke the maniphest.info method from conduit and ensure that:

  • The priorityColor property is given in the json
  • the priorityColor property is set correctly

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bwinterton retitled this revision from to Add a priorityColor property to the maniphest conduit endpoint.
bwinterton updated this object.
bwinterton edited the test plan for this revision. (Show Details)
bwinterton added a reviewer: epriestley.
This revision is now accepted and ready to land.Apr 9 2014, 6:31 PM
epriestley updated this revision to Diff 20717.

Closed by commit rPb660960771a4 (authored by @bwinterton, committed by @epriestley).