Page MenuHomePhabricator
Feed Advanced Search

May 20 2016

jpetso added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Write Depends on D123 in the commit message.

May 20 2016, 11:19 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
jpetso added a comment to T5000: Using Differential with plain Git, without requiring Arc.

If we are to support git push HEAD:review, I'd like users who are interested in this to explain exactly what they expect it to do, and why that's dramatically better than copy-and-paste.

May 20 2016, 10:55 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential

Mar 17 2016

jpetso created T10613: Include commit's branch information in activity feed.
Mar 17 2016, 6:40 PM · Diffusion, Feed, Feature Request

Mar 11 2016

jpetso created T10569: Subproject tasks in parent project backlog.
Mar 11 2016, 10:44 PM · Workboards, Projects, Feature Request

Jan 26 2016

exp10r3r awarded Roadmap a Love token.
Jan 26 2016, 9:01 AM

Nov 26 2015

jpetso added a comment to T9360: Unbeta Phame.

Yep, it was the Apache restart. Sorry for poor testing, thanks for fixing the incidentally discovered bug, and hopefully the other part of my comment was less useless :)

Nov 26 2015, 5:12 AM · Phame
jpetso added a comment to T9360: Unbeta Phame.

master as of yesterday (Tue) approx. 2 pm PST. When I get home I'll check if the logs match up, but I took care to pull all three repos and ran a storage upgrade.

Nov 26 2015, 2:10 AM · Phame
jpetso added a comment to T9360: Unbeta Phame.

Not opening another bug report since Phame is not out of beta yet, but I thought I should still let you know that I stumbled upon an exception yesterday after updating from before the comments revamp:

  • When viewing a Blog page (not a post itself): (Unable to resolve method 'isArchived'.)
  • When submitting a New Blog form: >>> UNRECOVERABLE FATAL ERROR <<< Undefined class constant &#039;TYPE_STATUS&#039;
Nov 26 2015, 1:50 AM · Phame

Nov 16 2015

aristedes awarded T7047: Add user preference for diffs in emails a Like token.
Nov 16 2015, 11:41 AM · Restricted Project, Differential, Mail, Diffusion

Nov 9 2015

jpetso added a comment to T9746: Figure out commenting in Phame.

Works for me!

Nov 9 2015, 8:45 PM · Phame
jpetso added a comment to T9746: Figure out commenting in Phame.

For reference, I think this is an excellent plan and I'm stoked to see internal comments being considered. (If I already have to get my users to sign up for a Phabricator account, it's good if they don't have to also log into Disqus.)

Nov 9 2015, 8:44 PM · Phame

Nov 8 2015

jpetso added a comment to T9737: Blog post not listed in "Create New" big plus icon menu.

Maybe there can be a way to enable it as a menu item, but being disabled by default. Your call! Thanks for getting back to me despite the beta label (forgot that you don't take bug reports / features on it yet).

Nov 8 2015, 8:35 PM · Phame
jpetso added a comment to T9737: Blog post not listed in "Create New" big plus icon menu.

In our community, for regular members (not involved in board/admin tasks), I expect it to be the one most commonly used action (the other common action being commenting on other people's posts). Either way, I can work with providing a separate link in a dashboard box. However, for a global menu I would find it confusing to not find "Create" actions in the "Create New" menu.

Nov 8 2015, 8:27 PM · Phame
jpetso created T9737: Blog post not listed in "Create New" big plus icon menu.
Nov 8 2015, 6:04 PM · Phame
jpetso created T9736: Provide default comment setting for blog posts.
Nov 8 2015, 5:57 PM · Phame

Sep 23 2015

jpetso edited the content of 2015 Week 37 (Early September).
Sep 23 2015, 2:19 PM

Sep 9 2015

jpetso added a comment to T9371: Subscribers not inherited for wiki pages.

@epriestley, I agree that in many situations you might not want to auto-subscribe to sub-pages. However, I'm not certain that having "Subscribers" appear on every sub-page is a bad thing - it allows customization if the inherited default is inappropriate for a given page.

Sep 9 2015, 3:22 PM · Phriction
jpetso added a comment to T9371: Subscribers not inherited for wiki pages.

@chad, I thought about that too, but this rule only comes into play after the page has been created. Since the view/edit permissions are inherited from the parent page, which has "Subscribers" access in this case, the form complains because without filled-in subscriber list, I "would no longer be able to view/edit the object". The form doesn't know about the Herald rule that makes this possible afterwards.

Sep 9 2015, 3:02 PM · Phriction
jpetso created T9371: Subscribers not inherited for wiki pages.
Sep 9 2015, 1:42 PM · Phriction

Sep 7 2015

jpetso added a comment to T9294: Phriction document-created email notifications do not include Edit Notes.

Possibly related, Edit Notes also don't show up in the Feed. At least for wiki page changes, they would make a lot of sense there. Please ignore this comment if it's not the same (or a similar) underlying technical issue.

Sep 7 2015, 11:54 PM · Phriction
jpetso created T9357: Internal announcements feed.
Sep 7 2015, 11:52 PM · Phame

May 5 2015

jpetso added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Potentially interesting (for integration or inspiration): http://blog.developer.bazaarvoice.com/2015/05/01/automating-a-git-rebase-workflow/

May 5 2015, 3:19 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential

Feb 4 2015

jpetso added a comment to T7047: Add user preference for diffs in emails.

Okay, so... I updated and that didn't help, but what did help was the realization that diffs are only included in (Herald rule) "Commit Hook: Commit Content" emails, never in "Commits" (i.e. push) emails even with the inlined-patches setting enabled. That means I'll have to send out multiple emails for pushes with multiple commits, but at least it works now. Thanks for helping out!

Feb 4 2015, 4:36 PM · Restricted Project, Differential, Mail, Diffusion

Jan 26 2015

jpetso added a comment to T7047: Add user preference for diffs in emails.

Restarting Phabricator hasn't made a difference. Will play around with it more tonight to see where things are still going wrong. Thanks for all your input, it's much appreciated :)

Jan 26 2015, 10:24 PM · Restricted Project, Differential, Mail, Diffusion
jpetso added a comment to T7047: Add user preference for diffs in emails.

Hm, I just pushed a couple of small changes to master and the commit email still only showed the summary. I had metamta.diffusion.attach-patches set to true and and metameta.diffusion.inline-patches set to 5000 (which should be more than enough for the few lines that were changed). The ones for metamta.differential were also set accordingly, although I guess that shouldn't matter as it didn't go through a code review in this case.

Jan 26 2015, 9:51 PM · Restricted Project, Differential, Mail, Diffusion
jpetso added a comment to T7047: Add user preference for diffs in emails.

Oh wait, I set it for Differential but not Diffusion. Let me verify that it works and I'll close the bug after. Thanks!

Jan 26 2015, 9:39 PM · Restricted Project, Differential, Mail, Diffusion
jpetso added a comment to T7047: Add user preference for diffs in emails.

Good point, I actually seem to have set that setting to 1000 before. However, none of our commit emails ever seems to include patches even below that number of lines. Maybe this has been fixed since I last updated our Phabricator instance?

Jan 26 2015, 9:38 PM · Restricted Project, Differential, Mail, Diffusion
jpetso updated the task description for T7047: Add user preference for diffs in emails.
Jan 26 2015, 9:20 PM · Restricted Project, Differential, Mail, Diffusion
jpetso created T7047: Add user preference for diffs in emails.
Jan 26 2015, 9:18 PM · Restricted Project, Differential, Mail, Diffusion