Page MenuHomePhabricator
Feed Advanced Search

Jun 24 2015

lpriestley added a revision to T8028: Fix PolicyControl defaulting nonsense in every application: Restricted Differential Revision.
Jun 24 2015, 9:52 PM · Calendar
lpriestley added a comment to T8361: Add a "click to see more" link to month view days with more than 15 events..

After you add the phutil_tag for the "View More" link, add a class to it, phui-calendar-month-get-more. Then go to the css file specified on line 63 and add that class to the bottom of that file, with position absolute, height of 18px, padding to line up with the text of the events, and a color of {$lightgreytext}.

Jun 24 2015, 12:21 AM · Calendar
lpriestley reassigned T8361: Add a "click to see more" link to month view days with more than 15 events. from lpriestley to SalmonKiller.

The Calendar application has several different builtin queries that provide different views of Calendar events:

  • Month view
  • Day view
  • Upcoming view
Jun 24 2015, 12:18 AM · Calendar

Jun 23 2015

lpriestley moved T7951: Write a "Calendar User Guide" and link it in the application from Backlog to Unprototype (v1) on the Calendar board.
Jun 23 2015, 5:07 PM · Calendar
lpriestley moved T8028: Fix PolicyControl defaulting nonsense in every application from Backlog to Unprototype (v1) on the Calendar board.
Jun 23 2015, 5:07 PM · Calendar
lpriestley moved T8361: Add a "click to see more" link to month view days with more than 15 events. from Backlog to Unprototype (v1) on the Calendar board.
Jun 23 2015, 5:07 PM · Calendar
lpriestley moved T8605: Date Picker does not use `Week Starts On` Setting from Backlog to Unprototype (v1) on the Calendar board.
Jun 23 2015, 4:19 PM · Calendar
lpriestley closed Restricted Maniphest Task, a subtask of T2334: Implement Google Calendar v3 API into Calendar, as Resolved.
Jun 23 2015, 4:16 PM · Restricted Project, Prioritized, Calendar
lpriestley closed Restricted Maniphest Task, a subtask of T7924: Unprototype Calendar (v1), as Resolved.
Jun 23 2015, 4:16 PM · Restricted Project, Prioritized, Calendar
lpriestley closed T8639: List view for calendar events should be able to show start and end dates as Resolved by committing Restricted Diffusion Commit.
Jun 23 2015, 1:44 AM · Calendar
lpriestley claimed T8639: List view for calendar events should be able to show start and end dates.
Jun 23 2015, 1:23 AM · Calendar
lpriestley moved T8639: List view for calendar events should be able to show start and end dates from Backlog to Unprototype (v1) on the Calendar board.
Jun 23 2015, 1:23 AM · Calendar
lpriestley added a revision to T8639: List view for calendar events should be able to show start and end dates: Restricted Differential Revision.
Jun 23 2015, 1:23 AM · Calendar

Jun 22 2015

lpriestley closed T7950: Support Projects in Calendar as Resolved.
Jun 22 2015, 8:28 PM · Calendar
lpriestley closed T7950: Support Projects in Calendar, a subtask of T7926: Modernize Calendar Infrastructure, as Resolved.
Jun 22 2015, 8:28 PM · Calendar
lpriestley added a revision to T7950: Support Projects in Calendar: Restricted Differential Revision.
Jun 22 2015, 8:04 PM · Calendar
mikn created T8639: List view for calendar events should be able to show start and end dates.
Jun 22 2015, 4:15 PM · Calendar

Jun 20 2015

epriestley added a comment to T7950: Support Projects in Calendar.

This might not be fully correct, but it should get you a little further:

Jun 20 2015, 5:05 PM · Calendar
epriestley closed T8340: Make pretty feed titles for recurring event edits as Resolved by committing Restricted Diffusion Commit.
Jun 20 2015, 4:45 PM · Calendar
lpriestley added a comment to T7950: Support Projects in Calendar.

In the middle of refactoring the search engine, started writing a custom date search field, but I'm not sure how to get/set it's value.

Jun 20 2015, 4:42 PM · Calendar

Jun 19 2015

epriestley closed T8032: Calendar description should render with Remarkup as Resolved by committing Restricted Diffusion Commit.
Jun 19 2015, 3:33 PM · Calendar
epriestley closed T8032: Calendar description should render with Remarkup, a subtask of T7925: Calendar v1 Errata, as Resolved.
Jun 19 2015, 3:33 PM · Calendar
SalmonKiller added a revision to T8032: Calendar description should render with Remarkup: Restricted Differential Revision.
Jun 19 2015, 5:12 AM · Calendar
lpriestley moved T8613: `rawResultLimit` getting set to 0 when querying for events for user availability from Backlog to Unprototype (v1) on the Calendar board.
Jun 19 2015, 4:37 AM · Calendar
lpriestley moved T8600: Event availability doesn't account for all day events from Backlog to Unprototype (v1) on the Calendar board.
Jun 19 2015, 3:58 AM · Calendar
lpriestley added a parent task for T8613: `rawResultLimit` getting set to 0 when querying for events for user availability: T8600: Event availability doesn't account for all day events.
Jun 19 2015, 3:57 AM · Calendar
lpriestley added a subtask for T8600: Event availability doesn't account for all day events: T8613: `rawResultLimit` getting set to 0 when querying for events for user availability.
Jun 19 2015, 3:57 AM · Calendar
lpriestley added a comment to T8600: Event availability doesn't account for all day events.

The problem was that all-day events were not in the correct timezone (we store them as UTC, but then convert them and pretend they're not UTC). Another problem that I discovered was that we weren't generating ghost events to see if any of them fit inside the "3 day availability window". There is one thing left here, and that's to figure out how to avoid getting a rawResultLimit of 0 - placeholder T8613

Jun 19 2015, 3:57 AM · Calendar
lpriestley created T8613: `rawResultLimit` getting set to 0 when querying for events for user availability.
Jun 19 2015, 3:57 AM · Calendar
lpriestley claimed T8600: Event availability doesn't account for all day events.
Jun 19 2015, 3:50 AM · Calendar
lpriestley added a revision to T8600: Event availability doesn't account for all day events: Restricted Differential Revision.
Jun 19 2015, 3:50 AM · Calendar
SalmonKiller added a revision to T8340: Make pretty feed titles for recurring event edits: Restricted Differential Revision.
Jun 19 2015, 12:43 AM · Calendar

Jun 18 2015

epriestley closed T8601: Fatal when viewing Calendar application on this instance as Resolved by committing Restricted Diffusion Commit.
Jun 18 2015, 10:11 PM · Calendar
• aHa created T8605: Date Picker does not use `Week Starts On` Setting.
Jun 18 2015, 7:53 PM · Calendar
epriestley added a revision to T8601: Fatal when viewing Calendar application on this instance: Restricted Differential Revision.
Jun 18 2015, 7:14 PM · Calendar
epriestley claimed T8601: Fatal when viewing Calendar application on this instance.
Jun 18 2015, 7:10 PM · Calendar
lpriestley closed T8050: Calendar List formatting as Resolved by committing Restricted Diffusion Commit.
Jun 18 2015, 6:02 PM · Calendar
epriestley assigned T8601: Fatal when viewing Calendar application on this instance to lpriestley.

I have a repro for this if you don't.

Jun 18 2015, 1:04 PM · Calendar
hach-que created T8601: Fatal when viewing Calendar application on this instance.
Jun 18 2015, 9:41 AM · Calendar
aik099 created T8600: Event availability doesn't account for all day events.
Jun 18 2015, 9:38 AM · Calendar

Jun 17 2015

lpriestley added a revision to T8577: InvalidArgumentException when viewing upcoming calendar events: Restricted Differential Revision.
Jun 17 2015, 3:29 PM · Calendar
lpriestley closed T8577: InvalidArgumentException when viewing upcoming calendar events as Resolved by committing Restricted Diffusion Commit.
Jun 17 2015, 3:12 PM · Calendar
lpriestley added a comment to T8577: InvalidArgumentException when viewing upcoming calendar events.

Sorry about this. Hopefully, I'll land a fix in the morning, but if you need to see events asap, the workaround is to use /calendar/query/advanced/. The issue is with saved queries, and advanced search is not a saved query.

Jun 17 2015, 7:14 AM · Calendar
lpriestley added a revision to T8577: InvalidArgumentException when viewing upcoming calendar events: Restricted Differential Revision.
Jun 17 2015, 7:06 AM · Calendar
• lavahot added a comment to T8577: InvalidArgumentException when viewing upcoming calendar events.

I can confirm this. I got this error when viewing the agenda widget on my dashboard today:

Jun 17 2015, 6:48 AM · Calendar
tiguchi created T8577: InvalidArgumentException when viewing upcoming calendar events.
Jun 17 2015, 5:27 AM · Calendar

Jun 16 2015

lpriestley added a revision to T8050: Calendar List formatting: Restricted Differential Revision.
Jun 16 2015, 10:44 PM · Calendar
epriestley closed T8460: Might be helpful for all ghost events (generated and concrete) to show what instance number they are. as Resolved by committing Restricted Diffusion Commit.
Jun 16 2015, 8:43 PM · Calendar
lpriestley claimed T8050: Calendar List formatting.
Jun 16 2015, 8:41 PM · Calendar
lpriestley closed T8568: Event create options should be "Regular" and "Recurring" instead of "Private" and "Public" as Resolved.
Jun 16 2015, 8:39 PM · Calendar
lpriestley closed T8046: Convert "Created By" and "Invited" to use PhabricatorPeopleUserFunctionDatasource in Calendar ApplicationSearch as Resolved by committing Restricted Diffusion Commit.
Jun 16 2015, 8:38 PM · Calendar
lpriestley closed T8046: Convert "Created By" and "Invited" to use PhabricatorPeopleUserFunctionDatasource in Calendar ApplicationSearch, a subtask of T7925: Calendar v1 Errata, as Resolved.
Jun 16 2015, 8:38 PM · Calendar
lpriestley added a revision to T8046: Convert "Created By" and "Invited" to use PhabricatorPeopleUserFunctionDatasource in Calendar ApplicationSearch: Restricted Differential Revision.
Jun 16 2015, 7:48 PM · Calendar
lpriestley added a parent task for T8032: Calendar description should render with Remarkup: Unknown Object (Maniphest Task).
Jun 16 2015, 7:28 PM · Calendar
lpriestley added a parent task for T8460: Might be helpful for all ghost events (generated and concrete) to show what instance number they are.: Unknown Object (Maniphest Task).
Jun 16 2015, 7:28 PM · Calendar
lpriestley added a revision to T8568: Event create options should be "Regular" and "Recurring" instead of "Private" and "Public": Restricted Differential Revision.
Jun 16 2015, 7:25 PM · Calendar
lpriestley reassigned T8340: Make pretty feed titles for recurring event edits from lpriestley to SalmonKiller.

When creating/editing events, transaction feed stories are generated for every transaction applied to the event object. Sometimes, the feed stories are grouped and prioritized, so that not all stories are visible. But each transaction that can be displayed, should have better text. Currently, event transactions for the recurring information should only be applied when creating an event, since you can not edit the recurring information of a recurring event after it is created.

Jun 16 2015, 7:06 PM · Calendar
lpriestley moved T8568: Event create options should be "Regular" and "Recurring" instead of "Private" and "Public" from Backlog to Unprototype (v1) on the Calendar board.
Jun 16 2015, 6:19 PM · Calendar
lpriestley created T8568: Event create options should be "Regular" and "Recurring" instead of "Private" and "Public".
Jun 16 2015, 6:18 PM · Calendar
SalmonKiller added a revision to T8460: Might be helpful for all ghost events (generated and concrete) to show what instance number they are.: Restricted Differential Revision.
Jun 16 2015, 5:11 PM · Calendar
lpriestley moved T8052: Calendar feed story should include description of event from Runners Up to Future Work (v2+) on the Calendar board.
Jun 16 2015, 3:27 AM · Calendar

Jun 15 2015

lpriestley moved T8032: Calendar description should render with Remarkup from Runners Up to Unprototype (v1) on the Calendar board.
Jun 15 2015, 10:58 PM · Calendar
lpriestley reassigned T8032: Calendar description should render with Remarkup from lpriestley to SalmonKiller.

First, to understand this task, let's compare how a description renders in a Calendar event versus, say, a Maniphest task. Create a Maniphest task with a description of something like:

```Some test description```

After saving the Maniphest task, you'll see the description render in the detail view as:

Some test description

If you repeat the same exercise with a Calendar event, this would not be true. The Calendar event detail view will show the saved description as:

```Some test description```

If you look at the PhabricatorCalendarEventEditController, the description control is added on line 440. Currently, the control is a AphrontFormTextAreaControl. It should be a PhabricatorRemarkupControl. Remarkup allows users to style their text and add meaningful text decorations. After you convert the description to the right control, the control in the edit view will now have a little menu along the top of the control that offers quick inserts of standard remarkup keys. However, if you save the description now, you will see that the description is still not rendered correctly in the detail view.
That view is built in PhabricatorCalendarEventViewController in the buildPropertyView method. You can use the same method in a similar file in the Spaces application for an example of this. After you implement that, refreshing that Calendar event you created should now render the description with remarkup. Let me know if I can clarify anything.

Jun 15 2015, 10:56 PM · Calendar
epriestley closed T8548: Fatal error in Conpherence: Call to a member function getName() on a non-object as Resolved by committing Restricted Diffusion Commit.
Jun 15 2015, 8:51 PM · Calendar, Conpherence
lpriestley closed T8551: Creating a recurring event does not save it as recurring as Resolved by committing Restricted Diffusion Commit.
Jun 15 2015, 6:53 PM · Calendar
lpriestley moved T8460: Might be helpful for all ghost events (generated and concrete) to show what instance number they are. from Backlog to Unprototype (v1) on the Calendar board.
Jun 15 2015, 5:39 PM · Calendar
lpriestley added a revision to T8551: Creating a recurring event does not save it as recurring: Restricted Differential Revision.
Jun 15 2015, 5:38 PM · Calendar
lpriestley moved T8551: Creating a recurring event does not save it as recurring from Backlog to Unprototype (v1) on the Calendar board.
Jun 15 2015, 5:28 PM · Calendar
lpriestley created T8551: Creating a recurring event does not save it as recurring.
Jun 15 2015, 5:28 PM · Calendar
lpriestley closed T8472: Allow safe editing of recurring events as Resolved.
Jun 15 2015, 5:24 PM · Calendar
lpriestley moved T5296: Allow user-defined date format from Backlog to Future Work (v2+) on the Calendar board.
Jun 15 2015, 5:23 PM · Calendar, User Delight, User Preferences
lpriestley closed T8319: Selecting "All Day" event hides both date and time inputs as Resolved.

I think there was a bug with ID's not being passed to Javascript, but I think I resolved that in passing. Closing for the moment, as the issue isn't reproducible in the current state.

Jun 15 2015, 5:21 PM · Calendar
lpriestley closed T8362: Set date time account preferences as Resolved.

Current notion of "recent" versus "standard" dates should expire as soon as date preferences have been specified.

Jun 15 2015, 5:20 PM · User Preferences, Calendar
lpriestley closed T8362: Set date time account preferences, a subtask of T5296: Allow user-defined date format, as Resolved.
Jun 15 2015, 5:20 PM · Calendar, User Delight, User Preferences
epriestley added a revision to T8548: Fatal error in Conpherence: Call to a member function getName() on a non-object: Restricted Differential Revision.
Jun 15 2015, 2:54 PM · Calendar, Conpherence
epriestley created T8548: Fatal error in Conpherence: Call to a member function getName() on a non-object.
Jun 15 2015, 2:46 PM · Calendar, Conpherence
lpriestley added a revision to T8362: Set date time account preferences: Restricted Differential Revision.
Jun 15 2015, 5:32 AM · User Preferences, Calendar

Jun 14 2015

lpriestley added a revision to T8362: Set date time account preferences: Restricted Differential Revision.
Jun 14 2015, 11:33 PM · User Preferences, Calendar

Jun 13 2015

lpriestley reassigned T8460: Might be helpful for all ghost events (generated and concrete) to show what instance number they are. from lpriestley to SalmonKiller.

Currently, a recurring event can be one of three types:

Jun 13 2015, 3:01 PM · Calendar

Jun 12 2015

lpriestley added a revision to T8362: Set date time account preferences: Restricted Differential Revision.
Jun 12 2015, 8:00 PM · User Preferences, Calendar
chad removed a subtask for T7924: Unprototype Calendar (v1): T7929: Integrate Calendar with external systems.
Jun 12 2015, 9:39 AM · Restricted Project, Prioritized, Calendar
chad removed a parent task for T7929: Integrate Calendar with external systems: T7924: Unprototype Calendar (v1).
Jun 12 2015, 9:39 AM · Calendar
• lavahot added a comment to T2334: Implement Google Calendar v3 API into Calendar.

@epriestley, You can't send this to v2 because it blocks T7924 through T7929. Huh, a task dependency tree tool might be cool.

Jun 12 2015, 8:43 AM · Restricted Project, Prioritized, Calendar

Jun 11 2015

chad added a comment to T7950: Support Projects in Calendar.

Maybe a better way to think about it, at least as I understand it, is Invite/Subscribe sends it to individual people and their calendars, but just tagging will not.

Jun 11 2015, 9:34 AM · Calendar
chad added a comment to T7950: Support Projects in Calendar.

Invite/Subscribe for Projects is for adding all people, like "Engineering" to an event. Tagging with a Project is different, as it's just stating this Event is defined by being a part of "Product" or whatever. Specifically, we intend to have a "Project Calendar" which will list everything happening by date for that Project (not people invited to said events).

Jun 11 2015, 9:32 AM · Calendar
devurandom added a comment to T7950: Support Projects in Calendar.

It is already possible to invite and subscribe projects. Ain't that even better than just tagging?

Jun 11 2015, 8:45 AM · Calendar

Jun 10 2015

lpriestley added a revision to T8472: Allow safe editing of recurring events: Restricted Differential Revision.
Jun 10 2015, 10:27 PM · Calendar
lpriestley claimed T8340: Make pretty feed titles for recurring event edits.
Jun 10 2015, 10:09 PM · Calendar
lpriestley reassigned T8340: Make pretty feed titles for recurring event edits from lpriestley to SalmonKiller.
Jun 10 2015, 5:06 PM · Calendar
lpriestley added a revision to T8362: Set date time account preferences: Restricted Differential Revision.
Jun 10 2015, 4:39 PM · User Preferences, Calendar

Jun 9 2015

lpriestley added a revision to T8472: Allow safe editing of recurring events: Restricted Differential Revision.
Jun 9 2015, 11:56 PM · Calendar
lpriestley added a revision to T8472: Allow safe editing of recurring events: Restricted Differential Revision.
Jun 9 2015, 3:53 AM · Calendar

Jun 8 2015

lpriestley added a comment to T8472: Allow safe editing of recurring events.

Yeah, and the worst case would be if E111/4 is actually E112, an exception, and E111 gets auto-converted to E222. Then E111/4, also known as E112, will no longer be part of the E222 sequence. We could start keeping track of the relationships, but that seems like a lot of work with little pay off and possibly way more confusion.

Jun 8 2015, 8:57 PM · Calendar
chad added a comment to T8472: Allow safe editing of recurring events.

Oh I guess that wouldn't work either if people linked to events.

Jun 8 2015, 7:21 PM · Calendar
lpriestley added a revision to T8357: Add recurrence end date: Restricted Differential Revision.
Jun 8 2015, 6:57 PM · Calendar
chad added a comment to T8472: Allow safe editing of recurring events.

Can we just do the destroy/rebuild for them automatically when they change the event?

Jun 8 2015, 6:51 PM · Calendar
lpriestley moved T8472: Allow safe editing of recurring events from Backlog to Unprototype (v1) on the Calendar board.
Jun 8 2015, 6:47 PM · Calendar
lpriestley changed the status of T8470: Cannot Edit Recurring Event from Duplicate to Wontfix.

This is by design, but, I agree, we should make this a better user experience. The idea is that generated instances of recurring events can have exceptions that hold an index in the sequence of generated events, and when a recurring event is edited from say a "weekly" event to a "daily" event, the index no longer makes sense. Right now, the expected workflow is to cancel the recurring event you wish to edit, and create a new recurring event to replace it.

Jun 8 2015, 6:47 PM · Calendar
lpriestley created T8472: Allow safe editing of recurring events.
Jun 8 2015, 6:34 PM · Calendar
chad merged task T8470: Cannot Edit Recurring Event into Restricted Maniphest Task.
Jun 8 2015, 6:32 PM · Calendar