Page MenuHomePhabricator
Create Task
Maniphest T8472

Allow safe editing of recurring events
Closed, ResolvedPublic
Actions

Description

Currently, recurring events cannot be edited, but really, the only ambiguous and unpleasant edits are date/time/frequency edits. Recurring events should be editable, and only the following fields can be edited:

  • title
  • description
  • invitee list
  • visibility
  • subscribers
  • icon

The following should never be editable on recurring events:

  • all day flag
  • recurring flag
  • recurrence frequency
  • recurrence end (up for debate, but leaning towards no)
  • start and end times

The fields that are not editable should have messaging that communicates the reason they are disabled/missing.

Revisions and Commits

rP Phabricator
D13241rP8a10cfbc9873 Fix missing recurrence end date control
D13230rPc075f7f63f71 Allow safe editing of recurring events
D13221rP7015520b9344 Add helper method on event object to determine if event is the parent of a…

Related Objects

Event Timeline

lpriestley created this task.Jun 8 2015, 6:34 PM
lpriestley claimed this task.
lpriestley raised the priority of this task from to Normal.
lpriestley updated the task description. (Show Details)
lpriestley added a project: Calendar.
lpriestley added a subscriber: lpriestley.
lpriestley mentioned this in T8470: Cannot Edit Recurring Event.Jun 8 2015, 6:47 PM
lpriestley moved this task from Backlog to Unprototype (v1) on the Calendar board.
chad added a subscriber: chad.Jun 8 2015, 6:51 PM

Can we just do the destroy/rebuild for them automatically when they change the event?

chad added a comment.Jun 8 2015, 7:21 PM

Oh I guess that wouldn't work either if people linked to events.

lpriestley added a comment.Jun 8 2015, 8:57 PM

Yeah, and the worst case would be if E111/4 is actually E112, an exception, and E111 gets auto-converted to E222. Then E111/4, also known as E112, will no longer be part of the E222 sequence. We could start keeping track of the relationships, but that seems like a lot of work with little pay off and possibly way more confusion.

An alternative philosophy, which has been adopted by Google calendar, is simply warn users that changes to a recurring event will destroy any exceptions. This seems less reasonable in a shared calendar.

lpriestley added a revision: D13221: Add helper method on event object to determine if event is the parent of a recurrence..Jun 9 2015, 3:53 AM
lpriestley added a commit: rP7015520b9344: Add helper method on event object to determine if event is the parent of a….Jun 9 2015, 4:40 AM
lpriestley added a revision: D13230: Allow safe editing of recurring events.Jun 9 2015, 11:56 PM
lpriestley added a commit: rPc075f7f63f71: Allow safe editing of recurring events.Jun 10 2015, 12:22 AM
lpriestley added a revision: D13241: Fix missing recurrence end date control.Jun 10 2015, 10:27 PM
lpriestley added a commit: rP8a10cfbc9873: Fix missing recurrence end date control.Jun 10 2015, 10:37 PM
lpriestley closed this task as Resolved.Jun 15 2015, 5:24 PM
Phabricator · Built by Phacility