Page MenuHomePhabricator
Feed Advanced Search

Mar 12 2019

epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: D20282: Allow "Move Tasks to Column..." to prompt for MFA.
Mar 12 2019, 9:20 PM · Workboards (v3), Plans, Projects

Mar 11 2019

epriestley updated the task description for T13074: Plans: Workboard triggers, groups, and subproject columns.
Mar 11 2019, 1:30 PM · Workboards (v3), Plans, Projects
epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: D20273: Allow MFA task edits to go through on workboards.
Mar 11 2019, 5:34 AM · Workboards (v3), Plans, Projects

Mar 9 2019

epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 8:34 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 7:16 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 7:15 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 7:12 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 6:58 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 6:50 PM · Plans
epriestley added a project to T13263: Plans: 2019 Week 11-15 Bonus Content: Plans.
Mar 9 2019, 6:43 PM · Plans
epriestley renamed T13249: 2019 Week 7 - 10 Bonus Content from 2019 Week 7 - 9 Bonus Content to 2019 Week 7 - 10 Bonus Content.
Mar 9 2019, 6:42 PM · Plans

Mar 7 2019

epriestley closed T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc), a subtask of T13088: Plans: Harbormaster UI usability and interconnectedness, as Resolved.
Mar 7 2019, 10:53 PM · Plans, Harbormaster
epriestley closed T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc) as Resolved.
Mar 7 2019, 10:53 PM · Plans, Harbormaster
epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: D20263: Remove the ability to drag tasks up and down on (non-Workboard) priority list views.
Mar 7 2019, 7:41 PM · Workboards (v3), Plans, Projects
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20259: On Harbormaster build plans, show which Herald rules trigger builds.
Mar 7 2019, 2:22 PM · Plans, Harbormaster
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20258: Modularize HeraldRule transactions.
Mar 7 2019, 1:02 PM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20257: Allow objects to specify custom policy unlocking behavior, and tasks to have owners unlocked.
Mar 7 2019, 4:52 AM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20256: Update "bin/policy unlock" to be more surgical, flexible, modular, and modern.
Mar 7 2019, 4:42 AM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20255: Fix an exception with user cache generation in "bin/conduit call --as <user>".
Mar 7 2019, 12:26 AM · Plans
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Mar 7 2019, 12:07 AM · Plans

Mar 6 2019

epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20252: Add an "Restartable: If Failed" behavior to Harbormaster build plans.
Mar 6 2019, 5:39 PM · Plans, Harbormaster
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20252: Add an "Restartable: If Failed" behavior to Harbormaster build plans.
Mar 6 2019, 5:39 PM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20251: Tweak the visual style of the ">>" / "<<" depth change indicators slightly.
Mar 6 2019, 4:36 PM · Plans
epriestley added a comment to T13074: Plans: Workboard triggers, groups, and subproject columns.

In the future, when a board can be ordered/grouped by author or assignee (or maybe custom fields), what should dragging a card within a column do?

Mar 6 2019, 3:11 PM · Workboards (v3), Plans, Projects
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Mar 6 2019, 2:54 PM · Plans
epriestley closed T11415: Would like people who can't edit Harbormaster plans to be able to run them, a subtask of T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc), as Resolved.
Mar 6 2019, 2:01 PM · Plans, Harbormaster

Mar 5 2019

epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Mar 5 2019, 5:57 PM · Plans
epriestley added a revision to T13253: Plans: Daemon Status Reporting: D20246: Give "bin/worker" flags to repeat and retry tasks.
Mar 5 2019, 1:36 AM · Plans, Daemons

Mar 2 2019

epriestley added a comment to T13253: Plans: Daemon Status Reporting.

Some old migrations call PhabricatorSearchWorker::queueDocumentForIndexing(). This no longer works after D20200 because the PHP implementation expects a dateCreated column to exist, but it won't exist until 20190220.daemon_worker.completed.02.sql runs.

Mar 2 2019, 2:04 PM · Plans, Daemons

Mar 1 2019

epriestley updated the task description for T13257: Plans: Unbeta New Harbormaster Log UI.
Mar 1 2019, 5:20 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 1 2019, 5:20 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 1 2019, 5:19 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20239: Add a warning to revision timelines when changes land with ongoing or failed builds.
Mar 1 2019, 3:54 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20236: Implement "Warn When Landing" behavior for Build Plans in Arcanist.
Mar 1 2019, 2:13 PM · Plans, Harbormaster

Feb 28 2019

epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20233: Implement Build Plan behavior "Affects Buildable".
Feb 28 2019, 9:24 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20232: Implement Build Plan "Hold Drafts" behavior.
Feb 28 2019, 9:12 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20230: Make the new Build Plan behavior "Restartable" work.
Feb 28 2019, 8:05 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20229: Make the new Build Plan "Runnable" behavior work.
Feb 28 2019, 7:41 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20228: Expose Build Plan behaviors via "harbormaster.buildplan.search".
Feb 28 2019, 7:01 PM · Plans, Harbormaster

Feb 26 2019

epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20220: Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing, restartable, runnable.
Feb 26 2019, 5:45 PM · Plans, Harbormaster
epriestley added a subtask for T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): T11415: Would like people who can't edit Harbormaster plans to be able to run them.
Feb 26 2019, 3:27 PM · Plans, Harbormaster
epriestley updated the task description for T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc).
Feb 26 2019, 3:26 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20219: Add a "Recent Builds" element to the Build Plan UI and tighten up a few odds and ends.
Feb 26 2019, 1:49 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20218: Provide "harbormaster.buildplan.edit" in the API.
Feb 26 2019, 1:24 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20217: Move Harbormaster Build Plans to modular transactions.
Feb 26 2019, 1:17 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Feb 26 2019, 12:48 PM · Plans, Harbormaster
epriestley updated the task description for T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc).
Feb 26 2019, 12:48 PM · Plans, Harbormaster
epriestley triaged T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc) as Normal priority.
Feb 26 2019, 12:41 PM · Plans, Harbormaster
epriestley triaged T13257: Plans: Unbeta New Harbormaster Log UI as Normal priority.
Feb 26 2019, 12:36 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D20216: Remove unusual "Created" element from Build Plan curtain UI.
Feb 26 2019, 12:35 PM · Plans, Harbormaster

Feb 23 2019

epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Feb 23 2019, 12:59 AM · Plans
epriestley renamed T13249: 2019 Week 7 - 10 Bonus Content from 2019 Week 7 - 8 Bonus Content to 2019 Week 7 - 9 Bonus Content.
Feb 23 2019, 12:58 AM · Plans

Feb 20 2019

epriestley added a comment to T13253: Plans: Daemon Status Reporting.

I'm looking at these storage/backend changes:

Feb 20 2019, 6:05 PM · Plans, Daemons
epriestley added a revision to T13253: Plans: Daemon Status Reporting: D20199: Remove some ancient daemon log code.
Feb 20 2019, 5:34 PM · Plans, Daemons
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Feb 20 2019, 1:15 PM · Differential, Plans
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20198: Don't enable the "ScopeEngine" or try to identify scope context for diffs without context.
Feb 20 2019, 1:10 PM · Differential, Plans
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Feb 20 2019, 5:04 AM · Differential, Plans
epriestley closed T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery, a subtask of T13161: Plans: Improve Differential diff display behaviors, as Resolved.
Feb 20 2019, 4:48 AM · Differential, Plans

Feb 19 2019

epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20195: Tweak some display behaviors for indent indicators.
Feb 19 2019, 11:00 PM · Differential, Plans
epriestley added a comment to T13161: Plans: Improve Differential diff display behaviors.
  • The "<<" and ">>" indicators are rendering in places where indentation has changed but the entire line is also different. This is not intended.
  • The ScopeEngine can raise an exception on diffs with partial context. We should probably just skip this feature if we're missing context.
  • The indent depth indicators are probably generally too bright / high-vis.
  • There's no color blind scheme for the indicators.
  • The indentation indicators in one-up mode aren't great (?)
Feb 19 2019, 10:42 PM · Differential, Plans

Feb 17 2019

epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20191: Behold! Copy text from either side of a diff!.
Feb 17 2019, 3:38 PM · Differential, Plans
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20189: Remove hidden zero-width spaces affecting copy behavior.
Feb 17 2019, 12:13 PM · Differential, Plans

Feb 16 2019

epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20188: Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers.
Feb 16 2019, 7:37 PM · Differential, Plans
epriestley added a subtask for T13161: Plans: Improve Differential diff display behaviors: T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.
Feb 16 2019, 5:51 PM · Differential, Plans
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Feb 16 2019, 4:42 PM · Differential, Plans
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20187: Put some whitespace behaviors back, but only for "diff alignment", not display.
Feb 16 2019, 4:31 PM · Differential, Plans
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20182: Add Arcanist support for highlighting indent change intraline diffs.
Feb 16 2019, 4:12 PM · Differential, Plans
epriestley added a comment to T13161: Plans: Improve Differential diff display behaviors.

Note that T6791 has an example of a change where removing the whitespace options is going to cause a behavioral regression. Here's an example:

Feb 16 2019, 2:43 PM · Differential, Plans
epriestley added a comment to T13161: Plans: Improve Differential diff display behaviors.

See PHI701. This behavior is not ideal:

Feb 16 2019, 2:18 PM · Differential, Plans
epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20185: Remove all whitespace options/configuration everywhere.
Feb 16 2019, 2:16 PM · Differential, Plans
epriestley added a comment to T13074: Plans: Workboard triggers, groups, and subproject columns.

I'm going to start here, and implement this proposed rule, which I think is the simpler and more intuitive of the proposals:

Feb 16 2019, 2:07 PM · Workboards (v3), Plans, Projects
epriestley moved T13074: Plans: Workboard triggers, groups, and subproject columns from Backlog to v3 on the Workboards board.
Feb 16 2019, 1:34 PM · Workboards (v3), Plans, Projects
epriestley renamed T13249: 2019 Week 7 - 10 Bonus Content from 2019 Week 7 Bonus Content to 2019 Week 7 - 8 Bonus Content.
Feb 16 2019, 3:20 AM · Plans

Feb 15 2019

epriestley added a revision to T13161: Plans: Improve Differential diff display behaviors: D20181: Render indent depth changes more clearly.
Feb 15 2019, 5:39 PM · Differential, Plans
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D20180: Allow unit tests to have arbitrarily long names (>255 characters).
Feb 15 2019, 3:19 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D20179: Give HarbormasterBuildUnitMessage a real Query class.
Feb 15 2019, 2:46 PM · Plans, Harbormaster
epriestley added a revision to T13253: Plans: Daemon Status Reporting: D20177: Queue search indexing tasks at a new PRIORITY_INDEX, not PRIORITY_IMPORT.
Feb 15 2019, 1:09 PM · Plans, Daemons
epriestley added a revision to T13253: Plans: Daemon Status Reporting: D20175: Correct schema irregularities (including weird keys) with worker task tables.
Feb 15 2019, 12:54 PM · Plans, Daemons
epriestley updated the task description for T13253: Plans: Daemon Status Reporting.
Feb 15 2019, 12:24 PM · Plans, Daemons
epriestley triaged T13253: Plans: Daemon Status Reporting as Normal priority.
Feb 15 2019, 12:20 PM · Plans, Daemons

Feb 14 2019

epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Feb 14 2019, 9:50 PM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20174: Make "Subscribe/Unsubscribe" require only "CAN_VIEW", not "CAN_INTERACT".
Feb 14 2019, 9:35 PM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20173: Show user availability dots (red = away, orange = busy) in typeaheads, tokenizer tokens, and autocompletes.
Feb 14 2019, 8:43 PM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20172: In "arc diff", warn when some reviewers are away even if not everyone is away.
Feb 14 2019, 6:29 PM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20171: Extract scope line selection logic from the diff rendering engine so it can reasonably be iterated on.
Feb 14 2019, 6:11 PM · Plans
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Feb 14 2019, 4:15 PM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20170: When users follow an email login link but an install does not use passwords, try to get them to link an account.
Feb 14 2019, 3:11 PM · Plans
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Feb 14 2019, 2:23 PM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20169: When users confirm Duo MFA in the mobile app, live-update the UI.
Feb 14 2019, 2:15 PM · Plans
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Feb 14 2019, 12:31 PM · Plans
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Feb 14 2019, 12:30 PM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20165: Allow task statuses to specify that either "comments" or "edits" are "locked".
Feb 14 2019, 3:10 AM · Plans

Feb 13 2019

epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20160: Bump the markup cache version for URI changes.
Feb 13 2019, 4:59 PM · Plans
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Feb 13 2019, 2:50 PM · Plans
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Feb 13 2019, 2:49 PM · Plans
epriestley added a comment to T13249: 2019 Week 7 - 10 Bonus Content.

bin/config set should warn you when a stronger database value exists, and point you toward bin/config delete --database.

Feb 13 2019, 2:46 PM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20159: Raise a setup warning when locked configuration has a configuration value stored in the database.
Feb 13 2019, 2:45 PM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20158: Rate limit attempts to add payment methods in Phortune.
Feb 13 2019, 1:18 PM · Plans
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Feb 13 2019, 1:06 PM · Plans
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Feb 13 2019, 1:03 PM · Plans