Page MenuHomePhabricator
Feed Advanced Search

Sep 1 2015

BYK retitled D14034: Prevent caching of workflows from to Only set `$workflow-conduit` if it's missing.
Sep 1 2015, 8:06 PM

Aug 28 2015

BYK added a comment to T9159: You may not set new credentials after authenticating conduit.

Seems like this happens when you have multiple layers of dependent diffs.

Aug 28 2015, 6:45 PM · Arcanist

May 14 2015

BYK added a comment to D8084: Add GenericXUnitTestEngine.

I think this test engine solves a real problem

May 14 2015, 1:51 PM
BYK added a comment to D8084: Add GenericXUnitTestEngine.

Any changes in this vein need to wait for T5568 and be reframed on top of that.

May 14 2015, 1:50 PM
BYK added a comment to T5568: Support `.arcunit`, similar to `.arclint`.

Since many engines support common output formats (I think?) like XUnit (I think?) separating parsing might be valuable here, while it's not very useful for lint.

May 14 2015, 1:49 PM · Unit, Arcanist

Mar 30 2015

BYK added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

It looks like this is probably not a bug then, and D12211 is a fairly reasonable fix.

Mar 30 2015, 10:01 PM · Firefox, Differential
BYK added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

I think this is the reason: http://stackoverflow.com/a/9014547/90297

Mar 30 2015, 9:53 PM · Firefox, Differential
BYK added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

@epriestley - I was able to narrow it down to this:

Mar 30 2015, 9:20 PM · Firefox, Differential
BYK added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

This looks like a bug in Firefox to me, but I imagine reducing it to a test case is quite involved.

Mar 30 2015, 6:43 PM · Firefox, Differential
BYK added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

We don't provide support alpha/beta browsers. All bug reports should be against stable browsers and HEAD.

Mar 30 2015, 6:37 PM · Firefox, Differential
BYK added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

Windows 8.1 EN with Firefox Aurora 38. That said I've had this issue for the last 2-3 versions so it should happen on latest stable Firefox too. I can verify if you want.

Mar 30 2015, 6:20 PM · Firefox, Differential
BYK reopened T7690: Unnecessary scroll bars for changesets in Firefox as "Open".

Here: https://secure.phabricator.com/D12210#1753cdf4

Mar 30 2015, 4:52 PM · Firefox, Differential
BYK created T7690: Unnecessary scroll bars for changesets in Firefox.
Mar 30 2015, 8:19 AM · Firefox, Differential
BYK added a comment to T7109: Mousewheel scrolling is sluggish in Firefox/Win.

This has been driving me and one of my colleagues crazy for a while now and he came with the following Stylish rule to get rid of it:

Mar 30 2015, 8:13 AM · Firefox, Windows, PHUI

Mar 24 2015

BYK added a comment to T5064: Make `arc land` run unit tests and lint.

For our case, we use both arc lint and arc unit. We have a somewhat "smart" unit test engine that tries to run only affected tests up to a degree so test times are not a huge concern to us. Also the team I work with is ~10 people so there's no way we can go as high as 30 commits/hour, at least in the near future. We have a smooth CI system that is running tests both for each diff revision and every commit on master.

Mar 24 2015, 10:14 AM · Restricted Project, Arcanist

Nov 19 2014

sascha-egerer awarded T5064: Make `arc land` run unit tests and lint a The World Burns token.
Nov 19 2014, 8:36 AM · Restricted Project, Arcanist

Sep 22 2014

BYK added a comment to D8084: Add GenericXUnitTestEngine.

Any updates?

Sep 22 2014, 7:50 AM
BYK abandoned D10220: Make all Node-based linters properly use `shouldUseInterpreter`.

Apparently this is not gonna happen so abandoning.

Sep 22 2014, 7:50 AM

Sep 10 2014

BYK added a comment to D10461: Fix ExternalLinter not passing file path for stdin option.

@joshuaspence - it does accept input from stdin but it was not working for me for some reason and I was too quick to read the code missing the actual part that passed the input. Apparently it is something related to my own system. Thanks for the heads up tho :)

Sep 10 2014, 2:17 PM
BYK abandoned D10461: Fix ExternalLinter not passing file path for stdin option.

Ah, damn I missed $future->write($this->getEngine()->loadData($path)); and got confused. Welp then this is definitely not the correct change yeah.

Sep 10 2014, 1:48 PM
BYK retitled D10461: Fix ExternalLinter not passing file path for stdin option from to Fix ExternalLinter not passing file path for stdin option.
Sep 10 2014, 9:21 AM

Aug 19 2014

BYK added a comment to D10220: Make all Node-based linters properly use `shouldUseInterpreter`.

I need to convince myself this is the best approach before I accept this. To do that, I need to research the answers to a lot of questions that I'm not very familiar with (like "Why doesn't node install binaries on Windows?"), reproduce the issue, etc.

Aug 19 2014, 7:27 AM

Aug 18 2014

BYK added a comment to D10220: Make all Node-based linters properly use `shouldUseInterpreter`.

Hello?

Aug 18 2014, 2:17 PM

Aug 11 2014

BYK retitled D10220: Make all Node-based linters properly use `shouldUseInterpreter` from to Make all Node-based linters properly use `shouldUseInterpreter`.
Aug 11 2014, 5:09 PM

May 15 2014

BYK added a comment to T5064: Make `arc land` run unit tests and lint.

The UI shows skipped. Instead, it should just be omitted or show tailored messages that this is an update from the VCS. This is easy and just a display issue.

May 15 2014, 1:45 PM · Restricted Project, Arcanist
BYK created T5064: Make `arc land` run unit tests and lint.
May 15 2014, 9:26 AM · Restricted Project, Arcanist