Page MenuHomePhabricator

Remove Controller->getHandle() and Controller->loadHandles()
ClosedPublic

Authored by epriestley on Mar 30 2015, 3:25 PM.
Tags
None
Referenced Files
F18715131: D12210.diff
Mon, Sep 29, 9:18 AM
F18605639: D12210.diff
Sat, Sep 13, 8:40 PM
F18471004: D12210.diff
Sep 2 2025, 6:41 PM
F18471003: D12210.diff
Sep 2 2025, 6:41 PM
F18098998: D12210.id29358.diff
Aug 9 2025, 12:26 AM
F18085137: D12210.id29358.diff
Aug 5 2025, 7:01 PM
F18081251: D12210.id29333.diff
Aug 4 2025, 11:13 PM
F17866339: D12210.diff
Jul 28 2025, 4:26 AM
Subscribers

Details

Summary

Ref T7689. Modernize all callsites of these methods.

Test Plan
  • Poked at dashboards.
    • Pretty sure this code is technically unreachable right now.
  • Viewed commit; viewed "Audit Status".
  • Viewed a fund; viewed "Payable to"; viewed "Owner".
  • Viewed herald rules; viewed "Author"; viewed "Applies To".
  • Viewed a Legalpad document; viewed "Contributors".
  • Viewed Phame post list; viewed blog; viewed post (viewed "Blog", viewed "Blogger").
  • Viewed a macro; viewed "Audio".
  • Viewed a Phriction page; viewed "Last Author".
  • Viewed a Ponder question; viewed "Author".
  • Viewed a Ponder answer; viewed header.
    • Behavior changed very slightly here; whatevs.
  • Viewed a Countdown; viewed "Author".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove Controller->getHandle() and Controller->loadHandles().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 8:06 PM
This revision was automatically updated to reflect the committed changes.