Page MenuHomePhabricator

Remove Controller->getHandle() and Controller->loadHandles()
ClosedPublic

Authored by epriestley on Mar 30 2015, 3:25 PM.
Tags
None
Referenced Files
F15458310: D12210.diff
Sun, Mar 30, 11:01 PM
F15391479: D12210.diff
Sat, Mar 15, 10:09 AM
F15390041: D12210.id29333.diff
Sat, Mar 15, 5:52 AM
F15305347: D12210.diff
Thu, Mar 6, 2:48 AM
Unknown Object (File)
Feb 8 2025, 3:18 AM
Unknown Object (File)
Feb 8 2025, 3:18 AM
Unknown Object (File)
Feb 8 2025, 3:18 AM
Unknown Object (File)
Jan 31 2025, 9:05 PM
Subscribers

Details

Summary

Ref T7689. Modernize all callsites of these methods.

Test Plan
  • Poked at dashboards.
    • Pretty sure this code is technically unreachable right now.
  • Viewed commit; viewed "Audit Status".
  • Viewed a fund; viewed "Payable to"; viewed "Owner".
  • Viewed herald rules; viewed "Author"; viewed "Applies To".
  • Viewed a Legalpad document; viewed "Contributors".
  • Viewed Phame post list; viewed blog; viewed post (viewed "Blog", viewed "Blogger").
  • Viewed a macro; viewed "Audio".
  • Viewed a Phriction page; viewed "Last Author".
  • Viewed a Ponder question; viewed "Author".
  • Viewed a Ponder answer; viewed header.
    • Behavior changed very slightly here; whatevs.
  • Viewed a Countdown; viewed "Author".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove Controller->getHandle() and Controller->loadHandles().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 8:06 PM
This revision was automatically updated to reflect the committed changes.