Fairly certain {D12647} fixed this. Closing this task, because not experiencing the bug described in this task.

• Other, more useful applications (Maniphest, Differential) don't currently do this.
  • PhabricatorApplicationTransactionFeedStory doesn't really support doing this the right way.
    • Audit implements it OK.
    • Pholio and Ponder implement it but sort of show the wrong data (the description at view-time, not at create-time, which is misleading).

As far as "creator" goes here, I'd probably try to make it just part of "Attendees". That is, in most cases it's just a single event with one attendee, that is the creator. We can add a tooltip maybe if needed to clarify or put Attendee: chad (creator) if needed. In cases where there are multiple attendees, the first person listed should be the creator.

yep, it's just old ones.

This is old events, right? Currently there shouldn't be a way to create non-titled events.

Funny, I forgot what the edit button was for also, but I put an inline comment on what it does in Pholio! It lets you change the start and end time of the day calendar. Not sure it thats a v2 feature, we could just hardcode a start and end time or maybe make it an admin config. But even for us if we spread geographically, we'll want to coordinate times a bit per individual.

such mentions

oh man, my name is in here like 4 times.

I hear Calendar is a thing now.

@chad, I agree typeaheads are good, and I agree that you invented them.

prevents typing "tea time", not acceptable

I'm partial to time typeaheads. Plus, I invented them.

What's left?

Still need to:

• Update existing uses of AphrontFormDateControl to use AphrontFormDateControlValue
• Figure out setAllowNull and how that translates to AphrontFormDateControlValue

Okay, I think we should do this:

Particularly, although it's conceptually simpler, paging/ordering is probably even messier. Paging/ordering is simpler if we have a single total order relation across all events, even if the order isn't exactly correct in some timezones.

An alternative is to only store date information for these events, then do two separate queries for time ranges:

I think this is:

I think the best way to do this is to create a new class to represent the state of a date control, like AphrontFormDateControlValue or something. Currently, AphrontFormDateControl has most of this logic, but that's awkward since it serves as both a Control and a value. This class will have fields like: