Page MenuHomePhabricator
Feed Advanced Search

Dec 30 2014

epriestley committed rP3f0bc79e0ab1: Minor JavaScript fix (authored by joshuaspence).
Minor JavaScript fix
Dec 30 2014, 10:50 AM · Blessed Reviewers
epriestley committed rPe3b3662ce919: Minor indentation fixes (authored by joshuaspence).
Minor indentation fixes
Dec 30 2014, 10:50 AM · Blessed Reviewers
epriestley committed rP0d1403833c52: Minor fixes for CSS linter issues (authored by joshuaspence).
Minor fixes for CSS linter issues
Dec 30 2014, 10:48 AM · Blessed Reviewers
epriestley committed rPeedd7aa58bc4: Minor linter fixes (authored by joshuaspence).
Minor linter fixes
Dec 30 2014, 10:48 AM · Blessed Reviewers
epriestley committed rPHU386f3cf61e4b: Relax text linter rules for XHPAST source code (authored by joshuaspence).
Relax text linter rules for XHPAST source code
Dec 30 2014, 10:47 AM · Blessed Reviewers
epriestley committed rARC841556134f6e: Fix `puppet-lint` unit tests for the v1.1.0 (authored by joshuaspence).
Fix `puppet-lint` unit tests for the v1.1.0
Dec 30 2014, 10:47 AM · Blessed Reviewers
epriestley committed rP9374ace60248: Ensure dateCreated property exists at index creation time (authored by WikiChad).
Ensure dateCreated property exists at index creation time
Dec 30 2014, 10:46 AM · Blessed Reviewers

Dec 29 2014

epriestley committed rP736857d1f62c: Setup check to install/enable pygments (authored by fabe).
Setup check to install/enable pygments
Dec 29 2014, 5:51 PM · Blessed Reviewers

Dec 28 2014

epriestley committed rP102e431feb01: Migrate Maniphest task blockers to modern EdgeType classes (authored by Krenair).
Migrate Maniphest task blockers to modern EdgeType classes
Dec 28 2014, 2:41 PM · Blessed Reviewers

Dec 24 2014

btrahan accepted rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.
Dec 24 2014, 7:02 PM · Blessed Reviewers

Dec 23 2014

epriestley added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

Hrrm, that sudo behavior is also broken. Looks like sudo -n is just messed up on OSX. I get this on a Linux system:

Dec 23 2014, 10:14 PM · Blessed Reviewers
fabe added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

Yep works fine now..

Dec 23 2014, 10:10 PM · Blessed Reviewers
btrahan added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

Huh, looks like the command output has changed. I probably had something funky from all the sudo su stuff... updated output with echo $?

Dec 23 2014, 9:53 PM · Blessed Reviewers
epriestley added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

Oh, the "slightly different" part matters. We try to do this write immediately after forking, which is why the failure is occurring.

Dec 23 2014, 9:53 PM · Blessed Reviewers
fabe added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

Ok, i can reproduce it with a user who's shell is set to /sbin/nologin ...

Dec 23 2014, 9:52 PM · Blessed Reviewers
epriestley added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

What's the exit status of that command? That is, if you run echo $? afterward, what does it print?

Dec 23 2014, 9:49 PM · Blessed Reviewers
btrahan added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

@fabe - ran that command for you...

Dec 23 2014, 9:45 PM · Blessed Reviewers
btrahan added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

Looking at the code, despite the daemons not starting correctly, a command exception must not be what is being thrown.

Dec 23 2014, 9:44 PM · Blessed Reviewers
fabe added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

When you start the daemons as btrahan it'll try to do a sudo -u _phd .... which you might not have the permissions for.
Normally this should result in an exception and the code will start the daemon as your normal user as a fallback.
If your sudo fails without the "CommandException" phd will think the daemons have started normally.
Can you try to manually run:
sudo -En -u _phd -- scripts/daemon/phd-daemon 'PhabricatorTaskmasterDaemon' --trace --verbose --phd='/var/tmp/phd/pid'
from your phabricator dir?

Dec 23 2014, 9:38 PM · Blessed Reviewers
epriestley added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

I was just doing that to make them switch, since I was logged in as epriestley instead of root, so without it they would not have needed to switch. Equivalently, I can do this (as root):

Dec 23 2014, 9:35 PM · Blessed Reviewers
btrahan added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

(Sorry, went and had lunch)

Dec 23 2014, 9:33 PM · Blessed Reviewers
epriestley added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

Try with --as-current-user, just as a sanity check?

Dec 23 2014, 9:04 PM · Blessed Reviewers
btrahan added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.
13:01:28 ~/Dropbox/code/phalanx (T5402)
~> ./bin/phd debug taskmaster
Usage Exception: You are trying to run a daemon as a nonstandard user, and `phd` was not able to `sudo` to the correct user.
Phabricator is configured to run daemons as "_phd", but the current user is "btrahan".
Use `sudo` to run as a different user, pass `--as-current-user` to ignore this warning, or edit `phd.user` to change the configuration.
Dec 23 2014, 9:02 PM · Blessed Reviewers
epriestley added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

This stuff is working OK for me locally on OSX. Let me check the same codepath you're going down, my config is slightly different...

Dec 23 2014, 9:01 PM · Blessed Reviewers
epriestley added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

Does phd debug taskmaster work?

Dec 23 2014, 9:01 PM · Blessed Reviewers
btrahan added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

I don't think its starting them correctly

Dec 23 2014, 9:01 PM · Blessed Reviewers
epriestley added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

Hrrm, we run ps -a ... so it should still be able to find them.

Dec 23 2014, 9:01 PM · Blessed Reviewers
epriestley added a comment to rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

The problem might be with the detection code -- maybe it's not seeing them because they're running as a different user? Are they not present in ps auxwww?

Dec 23 2014, 8:58 PM · Blessed Reviewers
btrahan raised a concern with rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise.

Daemons don't really seem to work for me anymore?

Dec 23 2014, 8:55 PM · Blessed Reviewers
epriestley committed rP2fedb6f941d8: Start phd daemons as the correctly configured user and refuse otherwise (authored by fabe).
Start phd daemons as the correctly configured user and refuse otherwise
Dec 23 2014, 4:16 PM · Blessed Reviewers
epriestley committed rP6132d8012b02: show the current size limit when a file upload fails (authored by fabe).
show the current size limit when a file upload fails
Dec 23 2014, 1:17 PM · Blessed Reviewers

Dec 22 2014

epriestley committed rPa366f85c118b: Properly create Elasticsearch index (authored by WikiChad).
Properly create Elasticsearch index
Dec 22 2014, 9:11 PM · Blessed Reviewers
epriestley committed rPc953c0fedc17: Switch normal query from match to simple_query_string (authored by WikiChad).
Switch normal query from match to simple_query_string
Dec 22 2014, 9:00 PM · Blessed Reviewers
epriestley committed rPbdda61184b73: Fixing typo unautorized -> unauthorized. (authored by austinkelleher).
Fixing typo unautorized -> unauthorized.
Dec 22 2014, 8:58 PM · Blessed Reviewers
epriestley committed rP853ce5e92704: setup warning for mysql with default boolean syntax (authored by fabe).
setup warning for mysql with default boolean syntax
Dec 22 2014, 8:57 PM · Blessed Reviewers

Dec 17 2014

joshuaspence committed rPed4c7893e900: Fix a exception being thrown from Diviner (authored by joshuaspence).
Fix a exception being thrown from Diviner
Dec 17 2014, 7:21 AM · Blessed Reviewers

Dec 10 2014

epriestley committed rPaeb4267b95f7: Don't show "Primary Hashtag" when creating a project (authored by lpriestley).
Don't show "Primary Hashtag" when creating a project
Dec 10 2014, 11:33 PM · Blessed Reviewers
epriestley committed rPedc4c219caa9: Title/Description quering for Passphrase credential (authored by lpriestley).
Title/Description quering for Passphrase credential
Dec 10 2014, 12:23 AM · Blessed Reviewers

Dec 9 2014

joshuaspence committed rP54f8aa8cd9f4: Minor linter fixes (authored by joshuaspence).
Minor linter fixes
Dec 9 2014, 7:38 AM · Blessed Reviewers

Dec 8 2014

epriestley committed rP4506018339a0: Clicking the search icon in empty search field should link to advanced search (authored by lpriestley).
Clicking the search icon in empty search field should link to advanced search
Dec 8 2014, 7:27 PM · Blessed Reviewers
joshuaspence committed rARC565a96e0ee54: Minor linter fixes (authored by joshuaspence).
Minor linter fixes
Dec 8 2014, 12:49 PM · Blessed Reviewers
joshuaspence committed rPHUdd243f1298de: Minor linter fix (authored by joshuaspence).
Minor linter fix
Dec 8 2014, 12:48 PM · Blessed Reviewers
joshuaspence committed rARC4ca3463df684: Extend `LINT_BRACE_FORMATTING` to support more scenarios (authored by joshuaspence).
Extend `LINT_BRACE_FORMATTING` to support more scenarios
Dec 8 2014, 12:34 PM · Blessed Reviewers
joshuaspence committed rARCee2070fadbc5: Extend `LINT_BRACE_FORMATTING` to warn on missing braces (authored by joshuaspence).
Extend `LINT_BRACE_FORMATTING` to warn on missing braces
Dec 8 2014, 12:34 PM · Blessed Reviewers
epriestley committed rP9e54e6e88661: Fix an undefined variable (authored by joshuaspence).
Fix an undefined variable
Dec 8 2014, 12:11 PM · Blessed Reviewers

Dec 2 2014

epriestley committed rPd923f68aad2a: performance optimazion for edge queries with getDestinationPHIDs (authored by fabe).
performance optimazion for edge queries with getDestinationPHIDs
Dec 2 2014, 1:52 PM · Blessed Reviewers

Nov 26 2014

epriestley committed rP013e953a4092: Fixed typo in Phame user guide (authored by dereckson).
Fixed typo in Phame user guide
Nov 26 2014, 1:07 PM · Blessed Reviewers