Page MenuHomePhabricator

Provide a Conduit method to get inline comments
ClosedPublic

Authored by vrana on Jun 23 2012, 6:07 AM.
Tags
None
Referenced Files
F15429659: D2844.id5298.diff
Mon, Mar 24, 3:30 AM
F15426223: D2844.id5298.diff
Sun, Mar 23, 7:46 AM
F15416638: D2844.id5293.diff
Thu, Mar 20, 12:40 PM
F15403930: D2844.id5298.diff
Tue, Mar 18, 5:35 AM
F15334147: D2844.diff
Sat, Mar 8, 7:04 AM
F15334086: D2844.id5293.diff
Sat, Mar 8, 6:43 AM
F15333660: D2844.id.diff
Sat, Mar 8, 3:49 AM
F15331336: D2844.id5298.diff
Fri, Mar 7, 9:00 AM
Subscribers

Details

Summary

See D2855 for usage.

This has a drawback that inlines without a comment (synthetic comments) are not attached anywhere.
I don't like adding more and more methods so I've chosen this solution.
Plus comments and inline comments are often useful together.

Test Plan

Called the method on a revision with inline comments.

Diff Detail

Branch
inlines
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

src/applications/conduit/method/differential/ConduitAPI_differential_getrevisioncomments_Method.php
96

Maybe this should also show which diffID the comment is on?

avivey changed the visibility from "All Users" to "Public (No Login Required)".