Differential D2844

Provide a Conduit method to get inline comments
ClosedPublic
Actions

Authored by vrana on Jun 23 2012, 6:07 AM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP43121f6858c4: Provide a Conduit method to get inline comments

Summary

See D2855 for usage.

This has a drawback that inlines without a comment (synthetic comments) are not attached anywhere.
I don't like adding more and more methods so I've chosen this solution.
Plus comments and inline comments are often useful together.

Test Plan

Called the method on a revision with inline comments.

Diff Detail

Branch

inlines

Lint

Lint OK

Unit

No Unit Test Coverage

Event Timeline

epriestley accepted this revision.Jun 23 2012, 1:36 PM

epriestley added inline comments.Jun 23 2012, 1:39 PM

src/applications/conduit/method/differential/ConduitAPI_differential_getrevisioncomments_Method.php
96	Maybe this should also show which diffID the comment is on?

Closed by commit rP43121f6858c4 (authored by @vrana).

dpaola2 mentioned this in T10776: Include comments in conduit differential.query results.Apr 11 2016, 7:09 PM

avivey edited edge metadata.Jun 6 2016, 8:52 PM

avivey changed the visibility from "All Users" to "Public (No Login Required)".

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

method/

differential/

ConduitAPI_differential_getrevisioncomments_Method.php

43 lines

Diff 5293

View Options

src/applications/conduit/method/differential/ConduitAPI_differential_getrevisioncomments_Method.php

Provide a Conduit method to get inline commentsClosedPublicActions