Page MenuHomePhabricator

Provide a Conduit method to get inline comments
ClosedPublic

Authored by vrana on Jun 23 2012, 6:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 1, 4:28 PM
Unknown Object (File)
Sun, Jun 29, 10:42 PM
Unknown Object (File)
May 30 2025, 11:23 AM
Unknown Object (File)
May 30 2025, 7:45 AM
Unknown Object (File)
May 29 2025, 1:12 PM
Unknown Object (File)
Apr 28 2025, 1:03 PM
Unknown Object (File)
Apr 28 2025, 11:11 AM
Unknown Object (File)
Apr 28 2025, 10:14 AM
Subscribers

Details

Summary

See D2855 for usage.

This has a drawback that inlines without a comment (synthetic comments) are not attached anywhere.
I don't like adding more and more methods so I've chosen this solution.
Plus comments and inline comments are often useful together.

Test Plan

Called the method on a revision with inline comments.

Diff Detail

Branch
inlines
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

src/applications/conduit/method/differential/ConduitAPI_differential_getrevisioncomments_Method.php
96

Maybe this should also show which diffID the comment is on?

avivey changed the visibility from "All Users" to "Public (No Login Required)".