Page MenuHomePhabricator

Provide a Conduit method to get inline comments
ClosedPublic

Authored by vrana on Jun 23 2012, 6:07 AM.
Tags
None
Referenced Files
F12832585: D2844.id.diff
Thu, Mar 28, 1:30 PM
Unknown Object (File)
Tue, Mar 19, 1:45 AM
Unknown Object (File)
Feb 4 2024, 2:15 AM
Unknown Object (File)
Jan 27 2024, 6:08 PM
Unknown Object (File)
Jan 27 2024, 12:01 AM
Unknown Object (File)
Jan 27 2024, 12:01 AM
Unknown Object (File)
Jan 16 2024, 6:11 AM
Unknown Object (File)
Dec 23 2023, 4:14 AM
Subscribers

Details

Summary

See D2855 for usage.

This has a drawback that inlines without a comment (synthetic comments) are not attached anywhere.
I don't like adding more and more methods so I've chosen this solution.
Plus comments and inline comments are often useful together.

Test Plan

Called the method on a revision with inline comments.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/conduit/method/differential/ConduitAPI_differential_getrevisioncomments_Method.php
96

Maybe this should also show which diffID the comment is on?

avivey changed the visibility from "All Users" to "Public (No Login Required)".