Differential D21068

Fix improper XHPAST parsing of namespace grammar like "use x as private;"
ClosedPublic
Actions

Authored by epriestley on Apr 7 2020, 9:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 21, 3:11 PM

	Unknown Object (File)
	Wed, Nov 20, 11:41 PM

	Unknown Object (File)
	Wed, Nov 20, 11:26 AM

	Unknown Object (File)
	Wed, Nov 20, 11:26 AM

	Unknown Object (File)
	Wed, Nov 20, 11:26 AM

	Unknown Object (File)
	Sun, Nov 10, 8:08 AM

	Unknown Object (File)
	Oct 22 2024, 11:19 AM

	Unknown Object (File)
	Oct 21 2024, 9:00 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5
Commits: rARCa1ee2ab93158: Fix improper XHPAST parsing of namespace grammar like "use x as private;"

Summary

Depends on D21067. Ref T13492. Converting unit tests to be readable exposed this error in the grammar.

Normally, "grammar_rule" rules emit a standalone Node. In this case, the bottom-level grammar rule is a collection of trivial rules and the callers configure the Node. Wrap the bottom-level rule in a configuration rule so the node is configured correctly and consistently, in exactly one place.

Test Plan

Ran unit tests.

Diff Detail

Repository

Branch

xhpast6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24006
Build 33042: Run Core Tests
Build 33041: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 7 2020, 9:24 PM

Harbormaster completed remote builds in B24006: Diff 50187.Apr 7 2020, 9:25 PM

epriestley requested review of this revision.Apr 7 2020, 9:25 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2020, 9:35 PM

Closed by commit rARCa1ee2ab93158: Fix improper XHPAST parsing of namespace grammar like "use x as private;" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCa1ee2ab93158: Fix improper XHPAST parsing of namespace grammar like "use x as private;".

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

php-traits.php.test

2 lines

bin/

PhutilXHPASTBinary.php

2 lines

support/

xhpast/

12 lines

parser.yacc.cpp

Diff 50187

src/parser/xhpast/tests/data/php-traits.php.test

Loading...

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...

support/xhpast/parser.y

Loading...

support/xhpast/parser.yacc.cpp

Loading...