Page MenuHomePhabricator

Fix improper XHPAST parsing of namespace grammar like "use x as private;"

Authored by epriestley on Apr 7 2020, 9:24 PM.



Depends on D21067. Ref T13492. Converting unit tests to be readable exposed this error in the grammar.

Normally, "grammar_rule" rules emit a standalone Node. In this case, the bottom-level grammar rule is a collection of trivial rules and the callers configure the Node. Wrap the bottom-level rule in a configuration rule so the node is configured correctly and consistently, in exactly one place.

Test Plan

Ran unit tests.

Diff Detail

rARC Arcanist
Lint Not Applicable
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2020, 9:35 PM
This revision was automatically updated to reflect the committed changes.